fix(manifest): harden v0.6.0 canonical writes and MSRV#298
Draft
Nelson Spence (Fieldnote-Echo) wants to merge 1 commit into
Draft
fix(manifest): harden v0.6.0 canonical writes and MSRV#298Nelson Spence (Fieldnote-Echo) wants to merge 1 commit into
Nelson Spence (Fieldnote-Echo) wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Nelson Spence (Fieldnote-Echo)
force-pushed
the
codex/manifest-content-address-hardening
branch
from
July 19, 2026 15:03
108fa63 to
8219786
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #297 so every review surface consistently targets the corrected
0.6.0train. Retarget tomainafter #297 merges.What changed
File::createmode/umask behavior for new Unix files and portable permissions for existing filesf64rusqlite 0.39because the 0.40 build dependency does not compile on the declared Rust 1.89 floorWhy
The manifest bytes are the bundle's content address. In-place truncation, feature-dependent JSON ordering, lossy paths, silent NaN-to-null conversion, and precision collisions all weaken that identity contract. Separately, the dependency bot's SQLite bump silently broke
ordvec-manifest --all-featureson the documented MSRV.The numeric path deliberately rejects values outside the exact canonical i64/u64/f64 domain instead of collapsing distinct arbitrary-precision inputs to the same bytes.
Validation
ordvec-manifest --all-features: 121 passedordvec-manifest --all-features --locked: 121 passed-D warningsCloses #294.
Closes #295.