Skip to content

Conversation

@Project516
Copy link
Owner

This pull request adds support for Fedora/RPM-based distributions and updates the Java version requirement across the project from Java 8 to Java 17. It introduces a new RPM packaging workflow, updates documentation and build scripts accordingly, and ensures the application and its packages depend on Java 17 or newer.

Fedora/RPM Packaging Support:

  • Added a new script package-rpm.sh to automate building RPM packages for Fedora, RHEL, CentOS, and similar distributions. This script builds the JAR, prepares the RPM build environment, and creates the .rpm package.
  • Added Fedora RPM spec file fedora-package/SPECS/numberguessinggame.spec and supporting .gitignore for build artifacts. The spec defines installation details, dependencies, and a wrapper script for launching the game. [1] [2]
  • Updated the GitHub Actions release workflow to install RPM build tools, build the RPM package, and upload the resulting .rpm files as release artifacts. [1] [2]

Documentation Updates:

  • Extended the README.md with installation and uninstallation instructions for Fedora/RPM-based systems, including example commands and download links. [1] [2]
  • Clarified and corrected Debian/Ubuntu installation instructions and fixed a typo in the .deb filename.

Java Version Upgrade:

  • Updated the Java version requirement from 8 to 17 in the README.md, build scripts (package-linux.sh, package-macos.sh, package-win.sh), and Gradle configuration. [1] [2] [3] [4] [5]
  • Updated Gradle's Java toolchain and test dependencies to use Java 17 and JUnit Jupiter 6.0.1.
  • Updated Debian and Fedora packaging to depend on Java 17 runtimes instead of Java 8. [1] [2]

Build and Dependency Management:

  • Cleaned up and modernized the app/build.gradle file, removing outdated comments and ensuring compatibility with the new Java version. [1] [2]

These changes collectively improve cross-distribution support, modernize the codebase for Java 17, and streamline the packaging and release process.

Copilot AI and others added 8 commits December 3, 2025 02:32
Co-authored-by: Project516 <138796702+Project516@users.noreply.github.com>
Co-authored-by: Project516 <138796702+Project516@users.noreply.github.com>
…-monorepo

Update dependency useJUnitJupiter to v6
Copilot AI review requested due to automatic review settings December 3, 2025 23:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades the Java version requirement from Java 8 to Java 17 and adds comprehensive Fedora/RPM packaging support to expand distribution compatibility. The changes modernize the build infrastructure while maintaining existing functionality.

Key Changes:

  • Java 17 migration across all packaging scripts, build configurations, and dependency definitions
  • New RPM packaging infrastructure with build script, spec file, and GitHub Actions integration
  • Documentation updates with Fedora/RPM installation instructions and corrected typos

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package-win.sh Updated Adoptium JRE download URL to fetch Java 17 instead of Java 8
package-macos.sh Updated Adoptium JRE download URL to fetch Java 17 instead of Java 8
package-linux.sh Updated Adoptium JRE download URL to fetch Java 17 instead of Java 8
package-rpm.sh New script to automate RPM package building for Fedora/RHEL/CentOS distributions
fedora-package/SPECS/numberguessinggame.spec RPM spec file defining package metadata, dependencies, installation, and changelog
fedora-package/SOURCES/.gitignore Excludes build artifacts from version control while preserving directory structure
debian-package/DEBIAN/control Updated Java dependency from Java 8 to default-jre for Java 17 compatibility
app/build.gradle Updated Java toolchain to version 17, cleaned up comments, and updated JUnit version
README.md Added Fedora/RPM installation instructions, fixed typo in .deb filename, updated Java requirement
.gitignore Added RPM package pattern and corrected Linux archive extension
.github/workflows/release.yml Integrated RPM build tools installation and RPM package generation into release workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Project516 Project516 merged commit f85e578 into release Dec 3, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants