Skip to content

feat(planner): recognize normalized SQL entropy in nats - #564

Closed
zzylol wants to merge 1 commit into
stack/509-18-exact-cardinalityfrom
stack/509-19-sql-frequency-entropy
Closed

zzylol wants to merge 1 commit into
stack/509-18-exact-cardinalityfrom
stack/509-19-sql-frequency-entropy

Conversation

@zzylol

@zzylol zzylol commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Problem: the #509 Example 2 entropy query (Q2) has no Entropy intent, so Pass 1 cannot offer summary candidates for it

#509 §Pass 1: Local candidate generation lists Entropy(x) with three local candidates: "Exact entropy, a specialized entropy summary, UnivMon". #509 §Example 2 ("One summary for several computations") then writes Q2 in SQL and says:

The SQL frontend does not yet recognize the Q2 and Q3 forms as Entropy and L2. TODO: add this recognition to the per-language frontends.

Q3 (L2) was recognized earlier in this stack. Q2 was not. Q2 is:

SELECT -SUM(p * LN(p))
FROM (
  SELECT COUNT(*) * 1.0 / SUM(COUNT(*)) OVER () AS p
  FROM flows
  WHERE ts >= now() - INTERVAL '1 minute'
  GROUP BY src_ip
);

Before this PR, the lowered graph is only relational. Nothing in it says "entropy":

Project(-col0)
└── Aggregate(SUM(p * LN(p)))                    no group keys
    └── Project(p = COUNT * 1.0 / total)
        └── SQLWindowFunc(SUM(COUNT) OVER ())    appends `total`
            └── Aggregate(COUNT(*) GROUP BY src_ip)
                └── Scan(flows) …

So Pass 1 has no FrequencyEntropy intent to attach the entropy-summary or UnivMon candidates to, and the Pass 2 summary-capability rule cannot put Q2 on a shared UnivMon with Q1 and Q3.

There are also two semantic traps in a naive rewrite:

  1. Units. AggIntent::FrequencyEntropy is "Shannon entropy in bits". The SQL uses LN, so the answer is in nats. A rewrite that returns the intent directly is off by a factor of ln 2.
  2. Empty input. SQL SUM over zero groups returns NULL. The L2 rewrite added earlier in this stack restored this with CASE WHEN l2 = 0.0 THEN NULL. That is fine while the statistic is exact. It is wrong once the statistic is approximate: an estimate may be 0.0 for nonempty input, and then the query would return NULL instead of a number. Entropy has the same problem worse, because exact entropy is 0 for any single-identity population.

Scope covered here. Recognition of the Q2 natural-log form as FrequencyEntropy (the "TODO" above, for entropy), with SQL units, NULL, and negative-zero behavior kept. The same exact population guard is applied to the existing L2 rewrite.

Left out. Native execution of the original Q2 graph (the SQL window and LN) is the next PR, #565. UnivMon accuracy for entropy is not certified. Pass 2 sharing partitions (Example 2's 37 candidates) are not enumerated.

Proposed method

The rule is a Pass 1 logical rewrite. It runs inside the existing SemanticEquivalentRewriteStrategy in asap-aware-mapping, on the common IR after the SQL frontend. It adds one alternative and keeps the original exact graph as another candidate.

Matching, top-down (all in frequency_rewrite.rs):

  1. Root is a Project with one item. After following projections (expand), the item is Negative(SQL) of column 0 (casts to Float64 are ignored).
  2. Below it is an ungrouped Aggregate with exactly one measure Sum { col }, no measure filters, no HAVING.
  3. Following projections from that column gives a product x * LN(x) (either order, SQL semantics). probability_term checks that the LN argument is structurally equal to the other factor.
  4. x is unit_count / Column(2) with SQL division and Float64 type. unit_count_term accepts Column(1) or Column(1) * 1.0 (either order). Any other scale, such as * 2.0, is refused.
  5. Column(2) comes from an SQLWindowFunc with func: Sum, args == [Column(1)], empty partition_by, empty order_by, and a frame of UNBOUNDED PRECEDING to UNBOUNDED FOLLOWING.
  6. The window's child is a grouped unit count (grouped_unit_count, shared with L2): one group key, one Count measure, no measure filter, no HAVING, and the key is a non-nullable Bool, Int64 or Utf8 field.

If every check passes, the rewrite builds (sql_frequency_result):

Project(alias = original name,
        CASE WHEN population_count = 0 THEN CAST(NULL AS Float64)
             ELSE -(0.0 - frequency_entropy * LN_2) END)
└── Join(Cross, true)
    ├── Aggregate(FrequencyEntropy { col: key, accuracy })   → frequency_entropy
    └── Aggregate(Count { accuracy: Exact })                 → population_count
        (both read the grouped count's input, so WHERE filters are kept)
  • * LN_2 converts bits to nats.
  • -(0.0 - x) equals x, except that x = 0 gives -0.0. SQL's -SUM(1 * LN(1)) is also -0.0, so a single-identity population keeps the same bit pattern.
  • population_count is always exact. The approximate statistic never decides whether the result is NULL.
  • accuracy is copied from the original COUNT(*) measure, which carries the query's target.
  • The rewrite is returned only if its output schema equals the original root schema.

The L2 rewrite now uses the same grouped_unit_count and sql_frequency_result. Its output changes from CASE WHEN l2 = 0.0 … to the exact-count guard. Its value expression is Column(0) (no unit change).

Key code interfaces

All new functions are crate-private. The public entry point is unchanged: SemanticEquivalentRewriteStrategy (in crates/asap-aware-mapping/src/rewrite.rs) now also calls the entropy rule in matches and replacements. In replacements the entropy rule is tried first.

crates/asap-aware-mapping/src/frequency_rewrite.rs:

pub(super) fn frequency_entropy_rewrite(root: &Rc<OperatorNode>) -> Option<Rc<OperatorNode>>;

// Shared by L2 and entropy.
fn grouped_unit_count(
    node: &Rc<OperatorNode>,
) -> Option<(usize, AccuracyTarget, Rc<OperatorNode>)>;

fn sql_frequency_result(
    root: &Rc<OperatorNode>,
    input: Rc<OperatorNode>,
    measure: AggIntent,
    name: &str,
    value: ScalarExpr,
) -> Option<Rc<OperatorNode>>;

fn probability_term(product: &ScalarExpr) -> Option<&ScalarExpr>;
fn unit_count_term(expr: &ScalarExpr) -> bool;

The replacement it emits (rewrite.rs):

ReplacementSubDAG {
    strategy: "SemanticEquivalentRewriteStrategy",
    replacement: Replacement::SubDAG(rewritten),
    provenance: ReplacementProvenance::LogicalRewrite,
    rationale: "recognize SQL natural-log entropy with explicit bits-to-nats conversion and exact empty-population guard".into(),
}

substitute (projection lineage) now also passes through ScalarExpr::Literal and ScalarExpr::Negative.

Usage (from crates/frontend-sql/tests/frequency_entropy.rs):

let root = lower_sql("SELECT -SUM(p * LN(p)) AS entropy FROM (SELECT COUNT(*) * 1.0 / SUM(COUNT(*)) OVER () AS p FROM flows GROUP BY src_ip) f", &catalog(false), AccuracyTarget::Exact).await?;
let replacements = SemanticEquivalentRewriteStrategy.replacements(&TargetSubDAG::new(&root));

Fields

frequency_entropy_rewrite

Item Type Meaning
root &Rc<OperatorNode> Candidate target root. Must be the outer Project of the Q2 shape.
return Option<Rc<OperatorNode>> The guarded entropy graph, or None if any check in "Proposed method" fails. None means "not this rule", not an error.

grouped_unit_count

Item Type Meaning
node &Rc<OperatorNode> Must be Aggregate { reduction: Reduce(keys), measures: [Count], having: None }.
return .0 usize Index of the single group key in the aggregate's input. Becomes col of the frequency intent.
return .1 AccuracyTarget The Count measure's accuracy. Becomes the statistic's accuracy.
return .2 Rc<OperatorNode> The aggregate's input (rows before grouping). Both new aggregates read it.

Refused when: keys.is_without(), any measure filter, key field nullable, or key type not Bool/Int64/Utf8. A nullable key is refused because GROUP BY makes a real NULL group that the frequency intent would skip.

sql_frequency_result

Item Type Meaning
root &Rc<OperatorNode> Original root. Supplies the output alias and qualifier, and the schema the result must equal.
input Rc<OperatorNode> Rows to count (from grouped_unit_count).
measure AggIntent FrequencyEntropy { col, accuracy } or FrequencyL2 { col, accuracy }.
name &str Output name of the statistic column: "frequency_entropy" or "frequency_l2".
value ScalarExpr The ELSE branch over the joined row (Column(0) = statistic, Column(1) = population_count). Entropy passes the nats/negative-zero expression; L2 passes Column(0).
return Option<Rc<OperatorNode>> None if node construction fails or the schema differs from root.schema.

probability_term / unit_count_term

Item Meaning
probability_term(product) For a * LN(b) or LN(b) * a with SQL semantics and a == b, returns a. Function name match is case-insensitive.
unit_count_term(expr) True for Column(1) or Column(1) * 1.0 / 1.0 * Column(1), ignoring Float64 casts. Column 1 is the COUNT output of the grouped aggregate.

AggIntent::FrequencyEntropy (existing, not changed): col: Option<C> is the identity column (a column index here); accuracy: AccuracyTarget is the target; the value is in bits.

Examples

End-to-end (crates/integration-tests/tests/sql_frequency_entropy.rs). Table flows(src_ip Utf8, keep Bool). Query:

SELECT -SUM(p*LN(p)) AS entropy
FROM (SELECT COUNT(*)*1.0/SUM(COUNT(*)) OVER () AS p FROM flows WHERE keep GROUP BY src_ip) f

Each case also has one ("discard", false) row that the WHERE keep must drop. The rewritten graph is executed natively:

Kept src_ip values Expected result
none NULL (population_count = 0)
a, a -0.0 (bit pattern checked)
a, a, b, b ln 2
a, a, a, b -0.75·ln 0.75 − 0.25·ln 0.25

Accepted vs refused shapes (crates/frontend-sql/tests/frequency_entropy.rs, declines_non_equivalent_entropy_shapes):

Shape Result Reason
COUNT(*)*1.0 / SUM(COUNT(*)) OVER (), LN, non-null src_ip rewrite Q2 form
COUNT(*)*2.0 / … refused probabilities scaled
-SUM(p*LOG2(p)) refused different log base
… OVER (PARTITION BY src_ip) refused partial total
… OVER (ORDER BY src_ip) refused running total
… GROUP BY src_ip HAVING COUNT(*) > 1 refused population changed
nullable src_ip refused NULL group

Other tests:

  • recognizes_sql_entropy_in_nats: rewritten schema equals the original; original has no entropy intent.
  • entropy_search_preserves_relational_alternative: search_workload_with_targets with default_strategies() returns candidates both with and without FrequencyEntropy.
  • entropy_accuracy_and_population_guard_are_separate: with EpsilonDelta { epsilon: 0.05, delta: 0.01 } (Q2's target), the entropy aggregate gets that target and the count aggregate gets Exact.
  • frequency_l2.rs, frequency_empty_input_guard_uses_an_exact_count: L2 with EpsilonDelta { 0.01, 0.01 } now has an exact Count on the right side of the join.

Out of scope

  • Native execution of the original Q2 graph (SUM(…) OVER (), LN): feat(runtime): execute exact SQL entropy fallback #565.
  • Other log bases, scaled probabilities, partitioned/ordered/finite windows, filtered measures, HAVING, nullable or other key types.
  • UnivMon accuracy for entropy; Pass 2 sharing partitions and resizing to the strictest consumer.
  • docs/develop_docs/planner-layering-status.md is updated to record what this step does and does not cover.

Stack and validation

Stacked on #563 (stack/509-18-exact-cardinality). Head: stack/509-19-sql-frequency-entropy. Next: #565.

Validation (from the current PR body):

  • The entropy recognition and exact L2 population-guard regressions fail before their changes.
  • Frontend recognition, refusal, accuracy and inventory tests pass.
  • Native wire execution verifies filtering, empty input, nats, negative zero and unequal frequencies.
  • Existing L2/distinct acceptance passes.
  • Formatting and affected all-target Clippy with warnings denied pass.

@zzylol

zzylol commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Parked as draft: PR priorities changed (see #528). Order is now (A) finish #511 operator sharing, (B) the #572 crate/module reorganization, (C) #509 end-to-end stages. This PR sits on the old stack/528-legacy-physical-base chain, and Phase B moves the files it touches. Its content will be re-scoped onto the new layout in Phase C.

@zzylol

zzylol commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

Ported onto the current stack in #598

zzylol added a commit that referenced this pull request Oct 4, 2026
Port of the parked #562 and #564 for #509 Example 2. The SQL frontend
names `SQRT(SUM(c*c))` over Float64 grouped unit counts as FrequencyL2,
and `-SUM(p*LN(p))` with `p = COUNT(*)*1.0 / SUM(COUNT(*)) OVER ()` as
FrequencyEntropy converted to nats. An exact population count guards
SQL's empty-input NULL. Integer products, nullable keys, filters, HAVING,
other log bases and partial windows are refused.

The rules are the old Pass 1 SemanticEquivalentRewriteStrategy rules, run
by lower_sql at the query root so the Stage 1 pipeline sees the intents;
the exact candidate is the native exact reducer. The executor gains SQL
sqrt (from #562).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zzylol

zzylol commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Closing: this parked chain (on stack/528-09-accuracy) has been superseded. Its content was ported or reimplemented further up the current stack, in #598, on the unified IR. Closed with the author's approval during the 2026-10-13 stack cleanup.

@zzylol zzylol closed this Oct 13, 2026
zzylol added a commit that referenced this pull request Oct 15, 2026
#509 Example 2 writes L2(src_ip) and Entropy(src_ip) as SQL idioms over
grouped unit counts. The SQL lowering (single query and batch) now names
them at the query root as FrequencyL2 / FrequencyEntropy aggregates
carrying the query's accuracy target, so Pass 1 offers exact and summary
candidates for each:

- L2: SQRT(SUM(c * c)) over COUNT(*) per key, only when the product is
  already Float64 (CAST(c AS DOUBLE) factors or CAST(COUNT(*) AS DOUBLE)).
  The Int64 product stays relational: SQL integer overflow is observable.
- Entropy: -SUM(p * LN(p)) with p = COUNT(*)[*1.0] / SUM(COUNT(*)) OVER ()
  over the complete unordered frame; the IR's bits are converted to nats
  and SQL's -0.0 is kept.

Both require a single non-nullable Bool/Int64/Utf8 key, no HAVING and no
measure filter, follow projections only, keep the original output schema,
and decide SQL's empty-input NULL by an exact population count joined
beside the statistic, never by an estimate. Scaled probabilities, LOG2,
partitioned or ordered windows and nullable keys stay relational.

Ports the frontend part of #598 (originally #562 and #564).
zzylol added a commit that referenced this pull request Oct 15, 2026
#509 Example 2 writes L2(src_ip) and Entropy(src_ip) as SQL idioms over
grouped unit counts. The SQL lowering (single query and batch) now names
them at the query root as FrequencyL2 / FrequencyEntropy aggregates
carrying the query's accuracy target, so Pass 1 offers exact and summary
candidates for each:

- L2: SQRT(SUM(c * c)) over COUNT(*) per key, only when the product is
  already Float64 (CAST(c AS DOUBLE) factors or CAST(COUNT(*) AS DOUBLE)).
  The Int64 product stays relational: SQL integer overflow is observable.
- Entropy: -SUM(p * LN(p)) with p = COUNT(*)[*1.0] / SUM(COUNT(*)) OVER ()
  over the complete unordered frame; the IR's bits are converted to nats
  and SQL's -0.0 is kept.

Both require a single non-nullable Bool/Int64/Utf8 key, no HAVING and no
measure filter, follow projections only, keep the original output schema,
and decide SQL's empty-input NULL by an exact population count joined
beside the statistic, never by an estimate. Scaled probabilities, LOG2,
partitioned or ordered windows and nullable keys stay relational.

Ports the frontend part of #598 (originally #562 and #564).
zzylol added a commit that referenced this pull request Oct 15, 2026
…and UnivMon frequency statistics (#707)

feat(types): summary-capability facts in the family-capability table

Each family lists the readouts one of its states answers (Readout:
total, item frequency, any quantile rank, distinct count, L2, entropy,
top-k), so a planner rule can check that one state serves every
consumer's statistic: UnivMon answers its total and every frequency
moment, KLL every rank, CountSketch item frequencies and L2, the heap
sketches top-k and item frequencies. Exact accumulators are read as
finalized values and answer no readout.
feat(logical-asap-optimization): Pass 2 summary-capability rule

Composition sizes each consumer's summary build alone, for its own
target. The summary-capability rule groups the builds of one candidate
that chose the same family over the same input sub-DAG (window, WHERE
and time range included), item and weight, grouping and filter, whose
every reader is an estimate the family answers (the family-capability
table's readouts), and that differ only in size. For every choice, per
group, of no sharing or one subset of two or more members whose sizes
differ (partial sharing included), the subset becomes one build sized
with each parameter's largest value among the members (a KLL's failure
probability and DDSketch's alpha: the smallest), and every guarantee
above it is composed again, so plan selection checks each consumer
against the shared state. Builds of equal size stay the
identical-expression rule's; unshared builds are untouched and no
consumer changes family.

Stage 1 lists each composed candidate, its identical-expression
candidates, then each summary-capability candidate followed by its own
identical-expression candidates, every distinct DAG once. The Pass 2
record (Pass2Candidate) names the shared summaries ("UnivMon for Q1,
Q3") and the shared identical groups.

Example 2 (PromQL stand-in): with #702's sizing the three UnivMons
differ (Q1 a distinct-count heap on 19 layers, Q2 the baseline shape for
entropy, Q3 a one-layer Count Sketch for L2), so the rule offers one
UnivMon for each pair and one for all three, each sized with the
members' largest heap, rows, columns and layers and the smallest
recorded distinct-count failure probability; the third query keeps its
own options. A shared UnivMon whose rows and columns together exceed
asap_sketchlib's hash budget (rows * (ceil(log2 cols) + 1) <= 128) is
not offered, since the library would not build it. The shared UnivMon
stays one build in Stage 2.
feat(frontend-sql): recognize the SQL frequency L2 and entropy idioms

#509 Example 2 writes L2(src_ip) and Entropy(src_ip) as SQL idioms over
grouped unit counts. The SQL lowering (single query and batch) now names
them at the query root as FrequencyL2 / FrequencyEntropy aggregates
carrying the query's accuracy target, so Pass 1 offers exact and summary
candidates for each:

- L2: SQRT(SUM(c * c)) over COUNT(*) per key, only when the product is
  already Float64 (CAST(c AS DOUBLE) factors or CAST(COUNT(*) AS DOUBLE)).
  The Int64 product stays relational: SQL integer overflow is observable.
- Entropy: -SUM(p * LN(p)) with p = COUNT(*)[*1.0] / SUM(COUNT(*)) OVER ()
  over the complete unordered frame; the IR's bits are converted to nats
  and SQL's -0.0 is kept.

Both require a single non-nullable Bool/Int64/Utf8 key, no HAVING and no
measure filter, follow projections only, keep the original output schema,
and decide SQL's empty-input NULL by an exact population count joined
beside the statistic, never by an estimate. Scaled probabilities, LOG2,
partitioned or ordered windows and nullable keys stay relational.

Ports the frontend part of #598 (originally #562 and #564).
feat(physical-operators): exact distinct, L2 and entropy reducers

Exact Cardinality, FrequencyL2 and FrequencyEntropy aggregates had no
native implementation, so the exact option of #509 Example 2's three
statistics could not execute.

- Reduction::Cardinality(cols) counts distinct tuples; a tuple with any
  NULL is skipped, and grouped key encoding keeps tuple boundaries and
  folds signed zero and NaN payloads.
- Reduction::FrequencyL2(col) and FrequencyEntropy(col) count the unit
  frequencies of one Bool/Int64/Float64/Utf8 identity column: NULL is
  skipped, a non-finite float is an error, an empty population gives 0.0,
  and entropy is in bits, as AggIntent::FrequencyEntropy and UnivMon's
  readout define it.
- The dictionaries are memory-accounted and cooperative.
- Logical aggregates bind them: grouped ones (SQL COUNT(DISTINCT)) and
  per-series range reductions (distinct_over_time, l2_over_time,
  entropy_over_time), which reduce each series' window samples, restore
  the run's timestamp and drop the metric name as range functions do.
- The analytical cost lowering prices them as hash aggregates.

Ports the exact-reducer part of #597 (from #559 and #563).
feat(physical-operators): native UnivMon state over typed identities

UnivMon had a kernel but no native DAG state: a build was rejected
("summary family has no native DAG state implementation"), a summary
build accepted only Float64 samples, and Pass 1's UnivMon update (each
value of the item column one unit occurrence) did not bind, so no
UnivMon candidate of #509 Example 2 could execute.

- UnivMon is a native family; its states validate against their
  parameters, and one state answers its total, distinct count, L2 norm
  and entropy.
- A UnivMon build takes Bool, Int64 and Utf8 identities as type-tagged
  key bytes (Int64 above 2^53 stays distinct) besides Float64 samples;
  NULL is skipped. Retained heap key bytes count toward state memory.
- A unit-frequency update over one item column binds, for UnivMon and
  HLL, as a value-frequency build over that column: grouped (SQL
  src_ip) and per series (PromQL sample values).

Ports the UnivMon part of #597 (from #557).
test(integration-tests): Example 2 in SQL; the recognized idioms execute

Example 2's SQL Q3 casts its counts to DOUBLE (the design's Int64
SUM(c * c) can overflow and stays relational), and the SQL Q2 and Q3
now lower to the entropy and L2 intents, so the SQL workload has the
PromQL stand-in's Pass 1 options. The recognized entropy executes in
nats with SQL's -0.0, L2 executes exactly, and both give NULL on empty
input, decided by the exact population count.
feat(devtools): stage_pipeline example planner-layering-2

stage_pipeline plans #509 Example 2: three SQL dashboard panels over
the last minute of flows (distinct sources at eps 0.02, entropy at
0.05, L2 at 0.01, delta 0.01), lowered over its flows(ts, src_ip)
table. SQL workloads lower every entry, batch and repeating, each with
its own accuracy target (lower_sql_batch read only batch entries).

The stage-viewer tab 2 row is regenerated from it: 82 plans, 16 from
Pass 1, the rest from the identical-expression and summary-capability
rules (one UnivMon for each pair of queries and for all three); 6
valid, P1 (all exact) selected at 6.08 per second. The row previously
said 8 plans were valid.
feat(logical-asap-optimization): guarantees through a join beside exact inputs and an exactly decided CASE

SQL Example 2's L2 decides the empty-input NULL from an exact population
count cross-joined beside the estimate and a CASE on that count. No
guarantee rule covered the join or the CASE, so every SQL plan with
UnivMon for Q3 was rejected ("the output has no guarantee"), although
the L2 estimate is certified.

- A join (inner, outer or cross) whose inputs are exact but one keeps
  that input's guarantee when its predicate reads only exact columns:
  which rows match, and how often, then does not depend on an estimate.
  A key on the approximate input's columns, a semi- or anti-join, or two
  approximate inputs have none.
- A CASE whose operand and conditions are exact keeps its weakest
  branch's guarantee; a literal or NULL branch, or a missing ELSE, is
  exact. A condition over an approximate value has none.
- A projection over such a join composes each output column this way.

Guarantees are per node, so every column of the approximate input counts
as approximate; column-level tracking (#689) stays the general solution.

A root's default metric (#690) looks through the same shape: a
projection whose CASE value branches read columns (or literals, cast or
not) takes those columns' metric, following them through joins and
row-preserving operators to an aggregate's measure, so SQL's L2 root
resolves to a relative target as the PromQL one does. Any other
expression stays absolute.
docs(stage-viewer): regenerate the Example 2 row with SQL L2 through UnivMon

With the join and CASE guarantee rules, the SQL Q3 UnivMon plans are
valid: 12 of the 82 plans are valid (Q3 exact or UnivMon), 70 invalid
(Q1 HLL or UnivMon without a distinct bound, Q2 UnivMon without an
entropy bound). P1 (all exact) is still selected at 6.08 per second;
UnivMon on Q3 costs 8.08.
fix(physical-operators): charge UnivMon key memory without walking its heaps

A build charges a state's memory after every input row, and UnivMon's
charge summed the bytes of every key on every layer's heap, so building
was quadratic in the heap: a 20,000-key heap on 19 layers over 40,000
keys took 3.3 s in release. The charge now bounds the retained keys by
every heap slot holding the longest key seen (tracked on insert, merge
and adoption of a decoded sketch), in constant time. A test checks that
the charge does not grow with heap occupancy; a timing test (ignored,
release) checks the large build.
fix(logical-asap-optimization): summary-capability review fixes

- A capability group of more than 63 builds is an error: one 64-bit mask
  enumerates the subsets of at most 63, and the shift was clamped, so a
  larger group was enumerated wrongly (and took 2^63 steps) instead of
  refused.
- A summary-capability variant whose guarantee composition fails carries
  its own error, so Stage 1 lists it as a candidate that cannot be
  composed and keeps the remaining variants; one failure used to drop
  them all.
- shared_size_params no longer claims every sizing bound is monotone (a
  Count Sketch's collision bound is tighter at a power-of-two width than
  one column wider); the shared state is checked by composing every
  guarantee above it again.
fix(logical-asap-optimization): read each column's guarantee in a projection over a join

A projection's guarantee assumed the error lies only in its child's
sample-value column (the column named "value", or the only numeric
one). Over a join that column can be an exact input's, so the
approximate input's columns were read as exact: projecting
sum(m) * 1000 beside the exact side's value composed to the
approximate side's absolute error 1, while the truth is 1000.

A projection over a join (directly, or through projections, filters,
sorts, limits or deduplication) now reads each column's own guarantee
(column_guarantees), and a projection over a computed projection over a
join, whose columns' guarantees are unknown, has none. Plan selection's
operand-domain lookup reads columns the same way. column_guarantees and
join_guarantee document their assumption that every approximate node of
Stage 1 has an exact row set. Per-column tracking in general is #689.
fix(logical-asap-optimization): refuse summary-capability groups of more than 20 builds

Every subset of two or more builds of a group is a candidate, 2^n of
them; past 20 builds (about a million) the rule returns an error naming
the limit instead of enumerating.
fix(physical-operators): bound UnivMon key memory by the key bytes inserted

Charging every heap slot at the longest key seen overcounts badly: one
1 KB key in a sketch of 19 layers of 20,000 slots was charged 380 MB.
Each layer's heap keeps at most one copy of a key, so the retained keys
are also bounded by the layers times the bytes of every key inserted
(or merged in); the charge takes the smaller bound, still in constant
time. asap_sketchlib exposes no eviction hook for an exact running
total.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant