Skip to content

test: remove the OTLP whole-backend process E2E - #789

Merged
zzylol merged 1 commit into
mainfrom
test/remove-otlp-process-e2e
Sep 29, 2026
Merged

zzylol merged 1 commit into
mainfrom
test/remove-otlp-process-e2e

Conversation

@zzylol

@zzylol zzylol commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Why

The data plane will not ingest OTLP. data_plane/tests/backend_process_e2e.rs
(production_control_plane_to_data_plane_otlp_to_promql) drives the path
controller → backend install → OTLP → store → PromQL, so it tests a path the
data plane is not going to support. It also only runs with an env var set by
scripts/e2e.sh whole, so a plain cargo test --workspace fails it locally.

What

Remove the test and everything that existed only for it:

  • data_plane/tests/backend_process_e2e.rs (the file held only this test).
  • The whole stage in scripts/e2e.sh, including its entry in all.
  • In CI, the "Build process-test control plane" step and the
    ASAP_E2E_CONTROL_PLANE_BIN export; no other test reads it.
  • The tokio-tungstenite dev-dependency of data_plane (control_plane
    still uses it).
  • References in manual-e2e-tests.md and precompute_engine_design_doc.md.

Before this PR

$ cargo test --workspace -- --test-threads=1
test production_control_plane_to_data_plane_otlp_to_promql ... FAILED
ASAP_E2E_CONTROL_PLANE_BIN is set by scripts/e2e.sh whole: NotPresent

After this PR

The test, its e2e.sh whole stage and its CI setup are gone.
./scripts/e2e.sh all runs contracts, control-plane, data-plane and monitor.

Remaining coverage

The supported paths keep their own process E2Es, so no replacement whole
stage is added (it would rerun the same tests):

  • Plan → backend install → Remote Write → store → PromQL:
    asapquery_compatibility_process_e2e (./scripts/e2e.sh asapquery).
  • ClickHouse backfill → store → SQL: clickhouse_q05_process_e2e and
    clickhouse_differential_e2e (need CLICKHOUSE_URL).

CI runs all of them once through cargo test --workspace.

Not in scope

differential and sketch-oracles also feed the data plane "modified OTLP"
fixtures. Whether to migrate or drop them is a separate decision.

Validation

cargo clippy --workspace --all-targets --locked -- -D warnings passes;
bash -n scripts/e2e.sh and ./scripts/e2e.sh list pass (no ignored tests).

🤖 Generated with Claude Code

The data plane will not ingest OTLP, so the controller -> backend -> OTLP
-> PromQL process test no longer describes a supported path. Remove it
with the `whole` e2e.sh stage, the CI control-plane build and env var
that only it used, its tokio-tungstenite dev-dependency, and the doc
references.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zzylol
zzylol merged commit ed1d21c into main Sep 29, 2026
1 check passed
@zzylol
zzylol deleted the test/remove-otlp-process-e2e branch September 29, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant