Repository navigation
test: remove the OTLP whole-backend process E2E - #789
Merged
Merged
Conversation
The data plane will not ingest OTLP, so the controller -> backend -> OTLP -> PromQL process test no longer describes a supported path. Remove it with the `whole` e2e.sh stage, the CI control-plane build and env var that only it used, its tokio-tungstenite dev-dependency, and the doc references. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The data plane will not ingest OTLP.
data_plane/tests/backend_process_e2e.rs(
production_control_plane_to_data_plane_otlp_to_promql) drives the pathcontroller → backend install → OTLP → store → PromQL, so it tests a path the
data plane is not going to support. It also only runs with an env var set by
scripts/e2e.sh whole, so a plaincargo test --workspacefails it locally.What
Remove the test and everything that existed only for it:
data_plane/tests/backend_process_e2e.rs(the file held only this test).wholestage inscripts/e2e.sh, including its entry inall.ASAP_E2E_CONTROL_PLANE_BINexport; no other test reads it.tokio-tungstenitedev-dependency ofdata_plane(control_planestill uses it).
manual-e2e-tests.mdandprecompute_engine_design_doc.md.Before this PR
After this PR
The test, its
e2e.sh wholestage and its CI setup are gone../scripts/e2e.sh allruns contracts, control-plane, data-plane and monitor.Remaining coverage
The supported paths keep their own process E2Es, so no replacement
wholestage is added (it would rerun the same tests):
asapquery_compatibility_process_e2e(./scripts/e2e.sh asapquery).clickhouse_q05_process_e2eandclickhouse_differential_e2e(needCLICKHOUSE_URL).CI runs all of them once through
cargo test --workspace.Not in scope
differentialandsketch-oraclesalso feed the data plane "modified OTLP"fixtures. Whether to migrate or drop them is a separate decision.
Validation
cargo clippy --workspace --all-targets --locked -- -D warningspasses;bash -n scripts/e2e.shand./scripts/e2e.sh listpass (no ignored tests).🤖 Generated with Claude Code