You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Compute EXPECTED_BUCKETS_PER_KEY instead of hardcoding it to 1 #575
In SimpleEngine::execute_and_merge_store_queries (asap-query-engine/src/engines/simple_engine/mod.rs), the Sliding-window branch hardcodes:
constEXPECTED_BUCKETS_PER_KEY:usize = 1;
This is only used to phrase a warn! when the store returns a different bucket count per key — it doesn't gate merge behavior (all buckets are merged regardless, per #570). But the constant itself is wrong whenever a sliding-window query's requested range spans more than one window width, per #554.
Both are available on the same aggregation_config_for_value already read in create_store_query_plan. When Total Range == Window Size (today's only supported case), this reduces to 1, matching current behavior.
Closed as solved on main. The hardcoded EXPECTED_BUCKETS_PER_KEY constant is gone; the active query path now computes and fetches the required non-overlapping Sliding-window exact cover, including wider
│ lookbacks (see #640). Verified by the current sliding-window range/instant equivalence tests.
Activity
fix(query-engine): warn instead of silently dropping keys with no pre…
fix(query-engine): warn instead of silently dropping keys with no pre…
fix(query-engine): merge all sliding-window buckets per key instead o…
milindsrivastava1997 commentedon Aug 27, 2026
Closed as solved on main. The hardcoded EXPECTED_BUCKETS_PER_KEY constant is gone; the active query path now computes and fetches the required non-overlapping Sliding-window exact cover, including wider
│ lookbacks (see #640). Verified by the current sliding-window range/instant equivalence tests.