query-engine: remove the unused sealed-epoch machinery from SimpleMapStore #870
Copy link
Copy link
Open
Description
Follow-up to #869 (review comment on global.rs).
Since #869, CircularBuffer no longer seals epochs: every window stays in the current MutableEpoch, whose distinct-window set is exact, and the oldest windows beyond the limit are evicted. No other policy seals either, so the sealed-epoch machinery is dead code in both stores:
- the
sealed_epochs: BTreeMap<EpochID, SealedEpoch>field and its read paths inper_key.rsandglobal.rs(range, exact and batch-exact queries, diagnostics, ReadBased cleanup); SealedEpoch,MutableEpoch::sealandSealedEpoch::unique_windowsincommon.rs, the last two currently#[allow(dead_code)];resolve_exact_windows'ssealed_epochsargument.
Remove them so each store holds one epoch per aggregation and retention is "the N newest distinct windows" by construction. Behavior shouldn't change, since the sealed maps are always empty, but compare range-query latency before and after: sealed epochs were sorted Vecs, kept for scan speed.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Activity