Repository navigation
Conversation
This was referenced Oct 15, 2026
Contributor
Author
|
Closing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
ASAPPlanner #462 implemented Float64 weighted CMS/CountSketch matrices and candidate heaps inside its physical-operator crate. The algorithms depended on Planner runtime values and could not be reused directly from sketchlib.
After this PR
WeightedFrequencyowns the matrix, hashing, estimation, typed candidate heap, merge, memory estimate and versioned snapshot logic in sketchlib. It exposes primitive typed tuple identities without a dependency on Planner, physical operators or execution scopes. ASAPPlanner retains only its parameter/value/trait adapter.For example, two updates of 0.125 and 0.25 to the same identity produce a 0.375 estimate without integer rounding. CMS accepts nonnegative weights; CountSketch accepts signed weights and uses sign-corrected median estimates at positive odd depth. Candidate retention does not establish TopK membership completeness.
Existing
ASAP-WFREQ-1bytes are preserved. This is separate from integer sketch and cross-language interchange formats. API documentation and a runnable example are included.Validation
Companion: ProjectASAP/ASAPPlanner#462