Skip to content

fix(events): omit unsupported chain filters - #2011

Closed
Osraka wants to merge 1 commit into
ProjectOpenSea:mainfrom
Osraka:osraka/fix-event-chain-query-scope
Closed

Osraka wants to merge 1 commit into
ProjectOpenSea:mainfrom
Osraka:osraka/fix-event-chain-query-scope

Conversation

@Osraka

@Osraka Osraka commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Motivation

GetEventsArgs.chain is valid for the account event feed, but the shared args type also lets collection and NFT event calls forward it. Neither endpoint documents that query parameter, and the NFT endpoint already identifies the chain in its path. This can produce an ignored filter or a contradictory URL.

Closes #2010

Solution

  • drop chain from the general, collection, and NFT event query paths
  • keep chain unchanged for account events
  • preserve collection trait encoding, pagination, and the NFT path chain
  • add sub-client and final URL regression coverage for all four states

Verification

  • npm test (1,239 tests)
  • npm run check-types
  • npm run format:check
  • npm run lint (passes with one pre-existing Function warning in test/provider/seaport-bridge.spec.ts)
  • npm run build

@ryanio

ryanio commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

thanks for the PR, this is in the latest release now!

@ryanio ryanio closed this Sep 16, 2026
pull Bot pushed a commit to Dustin4444/opensea-sdk that referenced this pull request Sep 16, 2026
Origin-SHA: 2c84e6e026f87821f153fa2c92d22753d5e99696

### Minor Changes

- cd6e615: Support Arc: offers use the 6-decimal USDC native mirror (0x3600…0000), listings use native USDC, approvals use the OS Ledger conduit. Native (0x0) offer currencies advertised by the API are normalized to the mirror.
- 0c24b3e: Support Stable Chain for offers and listings: offers use the 6-decimal USDT0 native mirror (0x779d…3736), listings use native gUSDT0, approvals use the OS Ledger conduit. Native (0x0) offer currencies advertised by the API are normalized to the mirror.

### Patch Changes

- Stop forwarding `chain` on `getEventsByCollection` and `getEventsByNFT`; only the account events endpoint documents that filter, and the NFT endpoint already carries the chain in its path. Thanks @Osraka ([opensea-sdk#2011](ProjectOpenSea#2011), fixes [opensea-sdk#2010](ProjectOpenSea#2010)).
- cd6e615: Sync OpenAPI spec: add `arc` chain identifier; agent relationships gain `ConfirmAgentRelationshipRequestBody` and optional `counterparty_account_id` addressing, `AgentRelationshipResponse` drops `initiator_address`/`counterparty_address`/`initiated_by`. `revokeAgentRelationship` serializes whichever counterparty identifier is provided (`counterpartyAccountId` or `counterpartyAddress`).
- Updated dependencies [fbbbea4]
- Updated dependencies [cd6e615]
  - @opensea/api-types@0.12.0

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Osraka <Osraka@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event collection and NFT endpoints send an unsupported chain query

2 participants