Stack the Venus atmosphere on the Magellan ground - #117
Draft
Protonmatter wants to merge 4 commits into
Draft
Protonmatter wants to merge 4 commits into
Protonmatter wants to merge 4 commits into
Conversation
Add attributed Solar System Scope materials behind a source-qualified-default selector, preserve physical state, and bound/cancel resource loads. RFC 0007 remains Draft pending design review and required rendering/CI gates.
Default Venus keeps its Magellan citation, artistic maps decode before lighting on both sphere programs, and the lifecycle tests lock texture identity, terrain, and context loss.
Keep the artistic cloud map when radar is on and composite it as a translucent shell instead of replacing the registered surface.
The lifecycle test loads the registered mosaic and checks the ground pass uses it while the artistic map stays on the shell.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Same head as pull request 115. The seven illustrative maps stay. Default Venus keeps its Magellan source row. Illustrative maps decode once before lighting on both sphere programs. With Magellan radar and Illustrative look both on, the registered radar mosaic stays the ground and
textures/illustrative/venus_atmosphere.jpgis drawn as a translucent shell above it. Lifecycle tests lock texture identity, terrain, that composite, and context-loss deletion.Specification and traceability
Correctness and risk
u_illustrativeLinearis 1 only on a draw that binds an artistic map.displayLinearskips a second decode. The registered surface row hides only when textures are off or Illustrative look replaces the surface. Venus radar does not replace the artistic atmosphere; mode 4 on the base sphere program samples that JPEG, derives coverage (translucent disk, thicker limb, no night veil), and blends it over the Magellan pass. The physical sphere program does not contain mode 4. The procedural limb is skipped while the shell is drawn.codex/planet-look-presets; do not merge this draft separately from Add optional illustrative looks for seven planets #115.UI and UX
Validation evidence
Commands and results:
The Venus lifecycle test checks two passes. Before the mosaic finishes loading, the ground does not bind the artistic texture. After that image loads, the ground pass is texMode 3 on the Magellan texture, and the shell pass still binds the artistic map at mode 4, with a 40 km display lift, straight alpha, depth test without depth write, and backface culling. A rasterized screenshot of that composite was not captured; this worktree has no built wasm package, so the page was not opened in a browser.
Documentation