Closed
Conversation
The default /var/log/mysql/error.log is not writable on GitHub runners.
Fix paths since steps run from villagesql-server/ working-directory: - VillageSQL_BUILD_DIR=/tmp/vsql-prometheus-exporter (was /tmp/vsql-prometheus-exporter/../../villagesql-server/build) - mysql socket: /tmp/vsql-prometheus-exporter/var/mysql.sock (was /tmp/vsql-prometheus-exporter/../var/mysql.sock) - extension path: /tmp/vsql-prometheus-exporter/../extension/build/... (correct) - MTR paths: /tmp/vsql-prometheus-exporter/../extension/mysql-test (correct) Also add docker/ci-validation/ for local CI testing simulation and local-ci.sh helper script.
Switch from $PWD relative paths to $GITHUB_WORKSPACE absolute paths to avoid confusion with working-directory defaults and cd commands. - VillageSQL_BUILD_DIR=$GITHUB_WORKSPACE/villagesql-server/build - mysql socket: $GITHUB_WORKSPACE/villagesql-server/var/mysql.sock - extension path: $GITHUB_WORKSPACE/extension/build/prometheus_exporter.veb - MTR suite: $GITHUB_WORKSPACE/extension/mysql-test - MTR tmpdir/socket: $GITHUB_WORKSPACE/villagesql-server/var/*
The INSTALL EXTENSION syntax takes only a name, not a path. The VEB file must be copied to the server's veb_dir first.
The veb_dir must be explicitly set at server startup since the default compile-time location is not writable in CI.
The --suite option expects a suite name, not a path. Copy extension's mysql-test into villagesql suite directory and use --do-suite prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger CI run