feat: add Docker Compose support for local orchestration (closes #15)#20
Merged
Conversation
Owner
Author
|
Note: Environment variables have been added to demonstrate Docker Compose configuration. The current version of |
10 tasks
gayathrii12
reviewed
Jul 17, 2026
gayathrii12
left a comment
Collaborator
There was a problem hiding this comment.
1)OG_LEVEL and CHECK_INTERVAL are configured in docker-compose.yml, but health-check.sh does not use them. Please implement their behavior, or remove them and update the PR description so it only claims configuration that works.
2)depends_on controls start order but does not guarantee that Nginx is ready to accept traffic. Since the monitor runs once and exits, please add a readiness check/health check or document that an initial network check can fail while the webserver starts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces Docker Compose support for the
linux-sysmonitorproject, making local development and orchestration simpler. The application can now be started with a single command while supporting persistent log storage, environment-based configuration, and multi-container networking.Changes
docker-compose.ymlfor local orchestration.sysmonitorservice to build from the local Dockerfile.sysmonitor_logs) to persist log files./app/logs.LOG_LEVELCHECK_INTERVALTARGET_HOSTwebserverservice using the officialnginx:alpineimage.sysmonitorto communicate with thewebserverservice using Docker Compose's default network.depends_onto ensure the webserver starts before the monitoring service.Validation
docker compose up --build.webserverservice through the default Docker Compose network.Notes
restart: unless-stoppedhas been deferred because the currenthealth-check.shis a one-time execution script. This will be enabled once the application is enhanced to run as a long-running monitoring service.journalctland CPU parsing issues are tracked separately and are outside the scope of this PR.