Repository navigation
Resolve SPHINX_APIDOC_OPTIONS, the niquests warning, and add Python 3.14 support - #84
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
stevepiercy
reviewed
Nov 2, 2026
stevepiercy
left a comment
stevepiercy
left a comment
Member
There was a problem hiding this comment.
@SashankBhamidi would like your feedback on reporting issues upstream. Please let me know. Thank you!
Member
Author
I already filed it yesterday, see jawah/niquests#487 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #79
Closes #80
Closes #82
SPHINX_APIDOC_OPTIONSwas set but never passed tosphinx-apidoc, now wired in via--automodule-options. No visible effect on rendered output,conf.pyalready sets the same options globally.The
sphinx_autodoc_typehintswarning is aniquestsbug (niquests/typing.py:171, an unresolvable forward reference). Filed upstream. Kept the local suppression, there's no fix available on our side.Added Python 3.14, tested and passing, zero code changes needed. Skipped 3.15, still alpha. Dropped 3.10 per #82.
#81 doesn't reproduce, confirmed with a clean rebuild. Closing separately.