Repository navigation
xfail Cyrus's inCalendar regression instead of blocking the suite - #92
Merged
Merged
Conversation
Documentation build overview
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SashankBhamidi
added
the
skip-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release.yml now blocks publish on integration tests passing (#89), which correctly caught that 8 tests fail against Cyrus on the already-known inCalendar regression (#91), not a client bug. Marked them xfail instead of letting them block every release.
Found two more stale assertions along the way: Cyrus no longer drops rel: enclosure attachments from search results, and no longer drops the attendee role from a participant's roles map (Stalwart still does, confirmed live). Both tests now assert the real, current behavior per server.