Repository navigation
Tests: a release pull request and its merge skip the suite - #204
Merged
Merged
Conversation
A release pull request changes only VERSION and CHANGELOG.md, so the suite ran twice more over code that had just passed: once on the pull request and once on its merge. Publishing still runs the suite at the release tag before anything goes out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release pull request changes only
VERSIONandCHANGELOG.md.CHANGELOG.mdwas already inpaths-ignore, butVERSIONwasn't, so the full Tests matrix (about 70 minutes) ran on the release pull request and again on its merge, over code that had just passed on main.This adds
VERSIONtopaths-ignorefor both triggers. A change that touchesVERSIONalongside anything else still runs the suite, becausepaths-ignoreskips only when every changed file matches. Lint still runs on a release pull request.publish-release-packages.ymlstill runs the suite,validate_apiand the library smoke at the release tag before it publishes, so a release is still gated on the tree it ships.