Repository navigation
Input ceilings: one stated level per effect, and the knobs that clip by design - #228
Merged
Merged
Conversation
CombFilter, LadderFilter, Reverb and TransientShaper each also stated a plucked phrase's clean level. Those tests probed above the new stated level, where the levels kit no longer plays, so they failed or passed on nothing. The stated level is now the one figure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each effect now says, in one sentence, how hot its input can be while its defaults and patches stay off the rails. The knobs that clip by design are named in one line instead of being excused cell by cell.
Seventeen effects state an input level below full scale, from -3 dBFS (Bitcrusher, LowPass) down to -24 dBFS (CombFilter, where two resonant patches build a DC offset up to the rail). Each level was measured with the ceiling kit on the defaults and every patch, 48 kHz stereo, across all its materials, in 3 dB steps. Each effect gets a quick test (1 to 15 s) that holds both halves: clean at the stated level, and red one step up on the setting that rails first. The thirteen effects that are clean at full scale state nothing, because full scale is what the kit holds them to anyway.
CLIPS_AT_TOPnames the macros whose top is meant to clip: an output Trim or Gain, a boost, Drive, Feedback, Attack. The ceiling kit skips the rail check where one of them sits at 127, and still judges wraps there. Ten effects declare it, each with a one-line note in its player text.test_kitplants cover both sides, and so doesCLIPS_BY_DESIGN = True, a class-wide form that no effect uses yet.CombFilter, LadderFilter, Reverb and TransientShaper also stated a plucked phrase's clean level, with tests that probed above the new stated level. Those sentences and tests are gone, so each effect states one level. The remaining older level notes (Reverb's noise and tone figures, ParametricEQ's headroom section, AnalogDelay's Mix ceiling) describe other things and stay.
Compressor, Overdrive, Exciter and Distortion follow separately.
Part of #147.