Repository navigation
HighPass, LowPass: CLAIMS tables for what the player text says - #231
Merged
Merged
Conversation
The module docstring's notes move to design-note comments. The class docstring says what the knobs do, the exact zero at DC, the slopes, where the corner reads Resonance, latency and level, and the CLAIMS table ties each of those to a test. kit_player holds the claims checker and the latency and missing-module readings the next tables share.
Same shape as HighPass. The corner is now checked at 40 Hz, where the text says it starts to read Resonance, and shown to fall short at 20 Hz.
A sentence wrapped across two lines was never found by the plant, so the check that a missing sentence goes red passed vacuously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #143. The two filters' docstrings become short player text: what the knobs do, the slopes, where the corner reads Resonance, latency, input level and what the class needs on a board. Each of those sentences has a row in a new
CLAIMStable naming the test behind it. The engineering notes that were in the module docstrings move, unchanged, into design-note comments.New tests: the corner reads Resonance from 40 Hz up and falls short below it; latency is zero on the patches; construction refuses without
audiobiquad.tests/support/kit_player.pyholds the claims checker and those two readings so the next tables can share them.