Repository navigation
DigitalDelay, PingPongDelay: bound the tail with Repeat Cut in - #232
Merged
Merged
Conversation
With Repeat Cut in circuit tail_samples was None. It now counts twice the laps it counts with the filter out (CUT_LAP_FACTOR). The high-pass can lift a lap's peak above the last one's, so the per-lap argument does not hold there and the factor is measured: across Feedback 0.40 to 0.99, Cut 20.3 to 400 Hz, 48 and 22.05 kHz, noise, random signs and sparse clicks, the longest tail took 1.35 times the filter-out count. The tests render the worst cells (Cut just above its out stop, Feedback 0.5 and 0.99, both rates) against the bound, and the count without the factor is outlived by full-scale noise. Part of #146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Repeat Cut in circuit,
tail_samplesonDigitalDelayandPingPongDelaywasNone, so a host could not know when the repeats stop. It now reports a bound there: twice the repeats it counts with the filter out (CUT_LAP_FACTOR).The high-pass sends each lap's value less the mean the loop has been carrying, and that can lift a lap's peak above the last one's, so the per-lap argument the filter-out bound rests on does not hold with Cut in. The factor is measured instead. Across Feedback 0.40 to 0.99, Cut 20.3 to 400 Hz, 48 and 22.05 kHz, full-scale noise, random full-scale signs and sparse clicks, mono and stereo, Repeat Tone out and at 800 Hz, and both ends of Spread, the longest tail took 1.35 times the filter-out count (
PingPongDelay, Feedback 0.5, Spread 1, Cut 20.3 Hz). At Feedback 0.99 it took 1.06 times.The tests render the worst cells (Cut just above its out stop, Feedback 0.5 and 0.99, 48 and 22.05 kHz, noise) and check each reaches exact zero inside the bound. A class without the factor is outlived by the noise and goes red.
Both test modules now declare
KIT_PLANTS: the planted delays that render differently from every knob stop and patch of the clean class, eleven forDigitalDelayand eight forPingPongDelay. The plant check passes all of them.Part of #146