Repository navigation
Ladder: keep a channel's state in locals for the block - #375
Merged
Merged
Conversation
Output and state bits are identical to the old ladder (0 of 13.9 M samples differ on desktop). On the ESP32-P4 DEV-KIT (128-frame blocks, median of 16): a 2x-oversampled ladder node 226 to 185 us a block (-18%), a 1x node 123 to 100 us, and Poly106 with six notes held 27.7 to 25.7 ms per 1024 frames. The five instruments' render hashes on the board match the old firmware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ladder keeps each channel's state in locals for the block, which makes it about 18% cheaper on the ESP32-P4 and changes no output.
On the ESP32-P4 DEV-KIT, at 128-frame blocks (median of 16), a 2x-oversampled ladder node goes from 226 to 185 µs a block, and a 1x node from 123 to 100 µs. Poly106 with six notes held goes from 27.7 to 25.7 ms per 1024 frames, and Poly6 from 34.8 to 32.9.
Output and state bits are identical to the old ladder: 0 of 13.9 M samples differ on desktop, and a planted one-ulp fault differs in 33,519 blocks. On the board, the render hashes of poly106, poly6, mono101, poly8 and polya6 match the old firmware.