Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #603.
combine("", " report.txt")currently returns"report.txt", removing a character from a valid filename. The same path change occurs duringMemoryFS.walk.files(path=""), so its returned path cannot be used to read the original file.Return the supplied path unchanged when the base is empty. This preserves filename spaces/tabs and the existing behavior for leading slashes. Other path combination behavior is unchanged.
Validation: both new path and MemoryFS traversal regressions fail against upstream. All 2656 project tests pass on supported Python 3.10.20 (26 existing skips); Black 22.3 and flake8 checks pass. The local environment uses
setuptools<81for the existingpkg_resourcesimport and pyftpdlib 1.5.9 within the project's declared range; pyftpdlib 1.5.10's test teardown expects a newer psutil API than the declared psutil 5.x dependency. No dependency files were changed.Prepared with AI assistance and independently reviewed before submission.