This repository was archived by the owner on Oct 2, 2021. It is now read-only.
Draft
Conversation
Member
Author
|
Hey @gbleaney sorry to pull you into this, but do you have a minute to take a look at the failing types job? Most of the failures seem to fall into two categories:
These all worked under pyre-check 0.0.46 but started failing in 0.0.48. I can try 0.0.47 if you think that will help but haven't yet since it isn't on PyPI. (The pytest-related failures could be related to pytest 6.0.0 adding annotations. I haven't dug into those yet.) |
This was referenced Aug 3, 2020
After upgrading to Pyre 0.0.48, these `pyre-ignore` comments are no longer needed.
These line length ignore rules were added to accommodate `pyre-ignore` comments. They are no longer needed and are being removed. Fortunately there was only one line of code that ended up being flagged for being too long. It's being refactored to account for the (once again) enforced limit.
This was referenced Oct 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately this upgrade isn't as simple as just updating the version number
in
tox.ini. Many of thepyre-ignorecomments are now unused (:success:). Inaddition to removing them, a couple that I originally thought I could remove now
need to stick around. We have to figure out why and address that.
Upon removing the comments, as per the TODO, the line length for these files no
longer needs to be ignored. The igores can be removed from the flake8
configuration. One line of code is being refactored to account for the line
length now being enforced for its file.
TODO: Address new type errors, either by fixing them or with ignores (which
could potentially change the above).