Feat: proximal module#200
Open
mrava87 wants to merge 39 commits into
Open
Conversation
This was referenced Jul 20, 2026
Contributor
Author
|
@rohanbabbar04 I have worked for quite a bit on this new (pretty big) feature... basically I am aiming to add a module called It would be great if you could go through and provide your review 😄 |
mrava87
marked this pull request as ready for review
July 20, 2026 22:31
Collaborator
|
Thanks @mrava87, I will take a look at this in a couple of days. |
Contributor
Author
|
Btw I noticed something strange lately.. in some PRs sometimes one action fails just at the start of the tests... but then if I retrigger them they eventually succeed... an example just occurred in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a starting point of an effort to support distributed proximal operators and solvers from
pyproximalin pylops-mpiTo begin with the following operators/solvers are supported:
pyproximaloperator into aMPIProxOperatorMPIL2which leverages distributed stacking and solvers to solve augumented systems of equations in the prox operator.ProximalGradientandADMML2solversThese already enable the solution of 2 typical use-cases of convex optimization:
reflectivitytutorialpoststacktutorial - note that for this to be possible, I needed to extendStackedDistributedArrayto operate with nestedStackedDistributedArray. This will be handled separately in Feat: allow nested stacked arrays #201 and then merged back into here.However, it is intentional that the operators/solvers implemented here do not always match those in
pyproximalwith some features currently missing, namely:TODO:
reflectivityGPU tutorials