Conversation
Collaborator
Author
|
@davide-f it would be good to have your looks on that. The major goal of this PR is to enable global applicability of GridBuilder creating a base to port results of this base if the regional grid modelling studies from global grid modelling. To facilitate generalisation, it can be handy to use composite_clean_build branch which has been created to incorporate into PyPSA-Eath grid modelling the approaches amended to it in PyPSA-Eur. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR brings in functionality to enable accuracy of GridBuilder when being applied to any country of the world.
Disclaimer
The implementation is build an a combination of PyPSA-Earth approach with learnings from the regional grid studies conducted during previous year by PyPSA-meets-Earth and MapYourGrid initiatives. I have updated the authors list accordingly, though it is not exhaustive yet.
Major changes
countryfield since it is crucial for correct assignment of conductor types. Bring-in regional line types #7 provides more details on that.Reviewer checklist
pipdependencies in the module's environment files (workflow/envs/).pathvars(e.g.,<results>) in their inputs and outputs.pre-commit.citests pass.INTERFACE.yamlmentions all relevantpathvarsandwildcards.README.mddescribes how to use the module and has the necessary citations.