feat: refactors temporal aggregation as a separate rule#1916
Open
tgilon wants to merge 5 commits intoPyPSA:masterfrom
Open
feat: refactors temporal aggregation as a separate rule#1916tgilon wants to merge 5 commits intoPyPSA:masterfrom
tgilon wants to merge 5 commits intoPyPSA:masterfrom
Conversation
2 tasks
Member
|
This PR would not be compatible with the approach proposed in #1838. @FabianHofmann presented this today and to me it looks like #1838 would be preferable (without having reviewed the code in detail yet) as it elegantly unifies overnight, myopic, and perfect foresight code. I would give that PR priority. One could always export the hourly model for reference as additional output. I will keep it open for now but close if #1838 gets merged. |
Merged
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
This PR introduces a new distinct rule to apply the time aggregation on the time-varying network data. To achieve this:
temporal_aggregationasbuild_snapshot_weightings, andtemporal_aggregationafterprepare_sector_networkthat effectively applies the aggregation.The benefit of doing this is that it makes the prepared network more explicit at hourly resolution.
Checklist
Changed dependencies are added topixi.toml(usingpixi add <dependency-name>).Changes in configuration options are added inconfig/config.default.yaml.Changes in configuration options are documented indoc/configtables/*.csv.Sources of newly added data are documented indoc/data_sources.rst.doc/release_notes.rstis added.