Skip to content

fix: use Path(str()) instead of resources.as_file() for alembic dir on Python < 3.12 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use Path(str()) instead of resources.as_file() for alembic dir on Python < 3.12 #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions backend/pyspur/cli/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,12 @@ def run_migrations() -> None:
if not script_location.is_dir():
raise FileNotFoundError("Migration scripts not found in package")

# extract migration scripts directory to a temporary location
with (
tempfile.TemporaryDirectory() as script_temp_dir,
resources.as_file(script_location) as script_location_path,
):
# Extract migration scripts to a temporary location for Alembic.
# resources.as_file() only supports files in Python < 3.12, so we
# convert the MultiplexedPath to a regular Path via str(), which
# returns the underlying filesystem path for installed packages.
with tempfile.TemporaryDirectory() as script_temp_dir:
script_location_path = Path(str(script_location))
shutil.copytree(script_location_path, Path(script_temp_dir), dirs_exist_ok=True)
# Create Alembic config programmatically
config = Config()
Expand Down