fix: repair broken error handling, deprecated model, and Windows crashes - #1
Open
Pyhroff wants to merge 1 commit into
Open
fix: repair broken error handling, deprecated model, and Windows crashes#1Pyhroff wants to merge 1 commit into
Pyhroff wants to merge 1 commit into
Conversation
- TAP and Crescendo now catch exceptions around API calls instead of crashing the whole run on a transient failure (rate limit, timeout, etc.) - Fix ci/sweep silently folding errored goals into the ASR denominator, which could misreport a failed scan as 0% ASR (model resisted) instead of flagging that the scan never actually ran; ci now fails the gate and sweep now shows an explicit error count instead of a false RESILIENT verdict - Replace deprecated/retired Groq model id (llama-3.3-70b-versatile) with a currently valid one everywhere it was hardcoded - Force UTF-8 stdout/stderr on Windows so rich's box-drawing/arrow characters don't crash on the default cp1252 console codepage - Fix defend's instruction-override regex missing stacked modifiers (e.g. "ignore all previous instructions") - Fix history command crashing on sqlite3.Row.get() - Fix TAP scan-result formatting (garbled '24n d3' -> '24 nodes (d3)') - Add category-filter error message listing valid categories - Add regression test for the errored-goals-must-fail-ci-gate behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ci/sweepsilently folding errored goals into the ASR denominator, which could misreport a failed scan as 0% ASR ("model resisted") instead of flagging that the scan never actually ran.cinow fails the gate on any errored goal, andsweepshows an explicit error count instead of a falseRESILIENTverdict.llama-3.3-70b-versatile) with a currently valid one everywhere it was hardcoded (.env.example,config.py, CLI option defaults, docstrings).defend'sinstruction_overrideregex missing stacked modifiers (e.g. "ignore all previous instructions" wasn't matched — only single-modifier phrasing was).historycrashing onsqlite3.Row.get()(Row doesn't support.get(), only dict does).24n d3now reads24 nodes (d3).Why
Ran a full manual audit of every CLI command against the live Groq API. Several of these were only exposed once real API calls were actually made (a rate-limit error during a live Crescendo run crashed it uncaught, which is what led to auditing and fixing TAP's identical gap before it could do the same). The ASR/errored-goals issue is the most consequential fix — as shipped, a
cigate could silently PASS when the scan never actually completed, which defeats the point of a CI safety gate.Testing
scanwith pair/tap/crescendo,sweep,ci,defend,history,report,serve,gcg) exercised against the live Groq API and/or a local HF model, not just imported