Fix bug in initialization routines to return solve with bounded nlp#3991
Open
stephenscini wants to merge 11 commits into
Open
Fix bug in initialization routines to return solve with bounded nlp#3991stephenscini wants to merge 11 commits into
stephenscini wants to merge 11 commits into
Conversation
Member
Author
|
@michaelbynum Please review when available. |
stephenscini
commented
Jul 8, 2026
michaelbynum
requested changes
Jul 9, 2026
michaelbynum
left a comment
Contributor
There was a problem hiding this comment.
This is almost perfect. One comment below. Also, the code for the final nlp solve is almost identical in all three methods. Could you move this to a helper function?
Member
Author
|
@michaelbynum Addressed comments. Please take another look when available. Thanks! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Fixes issue in initialization routines where the model is run through nlp solver before bounds are removed.
Summary/Motivation:
Currently: Original variables are bounded in methods and then there is cleanup but the initial point from lp, pwl, and global approximations is not verified to work with nlp_solver
Changes proposed in this PR:
AI-Use Disclosure
or
AI tools contributed to the development of this PR
Review process (select ONE):
Notes for reviewers (optional):
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: