test: make test_omp_get_wtime deterministic - #77
Merged
Merged
Conversation
The busy-wait asserted elapsed time within 5 ms (places=2). CI runner preemption past the deadline failed the macOS job intermittently. Timing accuracy belongs to libomp, not PyOMP. Keep binding coverage: omp_get_wtime is the only float64-returning _OpenmpExternalFunction, so the test checks a positive float from both njit and interpreted calls. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_omp_get_wtimebusy-waited for 0.25 s. It then asserted the elapsed time withassertAlmostEqual(delay, t, places=2), which allows only 5 ms of error. The loop cannot exit early, so the only possible error is overshoot. On shared CI runners, the process can be descheduled for more than 5 ms near the deadline. This made the macOS job fail intermittently.The test no longer measures time. It now checks that
omp_get_wtimecan be called from njit code and from interpreted Python, and that each call returns a positivefloat.