add actalis cert and some other limitations#33
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Actalis ACME support alongside ZeroSSL and enforces the Roborock onboarding token.r length limit.
Changes:
- Adds Actalis EAB config fields, secret-file handling, certificate issuance behavior, and related HA add-on options.
- Enforces a 32-character normalized onboarding server value in CLI and GUI flows.
- Updates tests, docs, Compose secret mounting, and configure output/help text.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_onboarding_gui.py |
Adds GUI onboarding length-limit coverage. |
tests/test_onboarding_cli.py |
Adds CLI onboarding length-limit coverage. |
tests/test_ha_addon.py |
Adds HA add-on ACME/EAB and stale secret tests. |
tests/test_configure.py |
Adds configure-flow assertions for ACME server and Actalis secrets. |
tests/test_config.py |
Adds config validation tests for Actalis EAB settings. |
tests/test_certs.py |
Adds certificate manager ACME command tests. |
start_onboarding.py |
Enforces normalized token.r length in CLI onboarding. |
start_onboarding_gui.py |
Enforces normalized token.r length in GUI onboarding. |
src/roborock_local_server/server.py |
Updates configure help text for generated ACME secrets. |
src/roborock_local_server/ha_addon.py |
Adds HA option handling and secret-file generation for Actalis EAB. |
src/roborock_local_server/configure.py |
Adds configure prompts, config rendering, and secret writing for Actalis. |
src/roborock_local_server/config.py |
Adds EAB fields, validation, and resolved paths. |
src/roborock_local_server/certs.py |
Passes EAB credentials to ACME and adjusts Actalis certificate domains. |
src/roborock_local_server/__main__.py |
Prints generated Actalis secret file paths. |
roborock_local_server_addon/config.yaml |
Exposes ACME server and EAB options in the HA add-on schema. |
README.md |
Adds a contributing section. |
docs/onboarding.md |
Documents the onboarding token.r length limit. |
docs/installation.md |
Documents generated Actalis secret files. |
docs/home_assistant.md |
Documents HA add-on ACME/Actalis options. |
docs/cloudflare_setup.md |
Documents configurable ACME CA behavior and issuance shape. |
compose.yaml |
Mounts the whole secrets directory for multiple generated secrets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.