Skip to content

add actalis cert and some other limitations#33

Merged
Lash-L merged 4 commits into
mainfrom
actalis_cert
May 16, 2026
Merged

add actalis cert and some other limitations#33
Lash-L merged 4 commits into
mainfrom
actalis_cert

Conversation

@Lash-L
Copy link
Copy Markdown
Contributor

@Lash-L Lash-L commented May 14, 2026

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Actalis ACME support alongside ZeroSSL and enforces the Roborock onboarding token.r length limit.

Changes:

  • Adds Actalis EAB config fields, secret-file handling, certificate issuance behavior, and related HA add-on options.
  • Enforces a 32-character normalized onboarding server value in CLI and GUI flows.
  • Updates tests, docs, Compose secret mounting, and configure output/help text.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tests/test_onboarding_gui.py Adds GUI onboarding length-limit coverage.
tests/test_onboarding_cli.py Adds CLI onboarding length-limit coverage.
tests/test_ha_addon.py Adds HA add-on ACME/EAB and stale secret tests.
tests/test_configure.py Adds configure-flow assertions for ACME server and Actalis secrets.
tests/test_config.py Adds config validation tests for Actalis EAB settings.
tests/test_certs.py Adds certificate manager ACME command tests.
start_onboarding.py Enforces normalized token.r length in CLI onboarding.
start_onboarding_gui.py Enforces normalized token.r length in GUI onboarding.
src/roborock_local_server/server.py Updates configure help text for generated ACME secrets.
src/roborock_local_server/ha_addon.py Adds HA option handling and secret-file generation for Actalis EAB.
src/roborock_local_server/configure.py Adds configure prompts, config rendering, and secret writing for Actalis.
src/roborock_local_server/config.py Adds EAB fields, validation, and resolved paths.
src/roborock_local_server/certs.py Passes EAB credentials to ACME and adjusts Actalis certificate domains.
src/roborock_local_server/__main__.py Prints generated Actalis secret file paths.
roborock_local_server_addon/config.yaml Exposes ACME server and EAB options in the HA add-on schema.
README.md Adds a contributing section.
docs/onboarding.md Documents the onboarding token.r length limit.
docs/installation.md Documents generated Actalis secret files.
docs/home_assistant.md Documents HA add-on ACME/Actalis options.
docs/cloudflare_setup.md Documents configurable ACME CA behavior and issuance shape.
compose.yaml Mounts the whole secrets directory for multiple generated secrets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/roborock_local_server/certs.py
Comment thread src/roborock_local_server/configure.py Outdated
Comment thread src/roborock_local_server/configure.py
Comment thread README.md Outdated
Comment thread docs/cloudflare_setup.md Outdated
Comment thread docs/installation.md
Comment thread src/roborock_local_server/config.py
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.

Comment thread src/roborock_local_server/certs.py
Comment thread src/roborock_local_server/ha_addon.py Outdated
Comment thread src/roborock_local_server/certs.py
Comment thread tests/test_onboarding_gui.py Outdated
Comment thread tests/test_onboarding_cli.py Outdated
@Lash-L Lash-L merged commit dd9195b into main May 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants