-
Notifications
You must be signed in to change notification settings - Fork 204
Add Pixi workflow to verify Pyodide build works #1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IvanIsCoding
wants to merge
50
commits into
Qiskit:main
Choose a base branch
from
IvanIsCoding:pixi-pyodide
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,598
−3
Open
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
7bdeaff
Pyodide: force only one thread
IvanIsCoding 7ce8078
Add .cargo/config.toml
IvanIsCoding b440e6b
Unstable feature that makes rayon work
IvanIsCoding e70b263
Newline
IvanIsCoding bf15e3b
Merge remote-tracking branch 'upstream/main' into pyodide-rayon
IvanIsCoding 76f5dff
Document pyodide
IvanIsCoding 4b17893
Add release note for pyodide
IvanIsCoding 0e3b0ce
Fix separator
IvanIsCoding 3527a6f
Consolidate the bare minimum of flags
IvanIsCoding 72ceb1a
Add emscripten-wasm-eh flag
IvanIsCoding 65d4eb8
Use pixi to have a reproducible pyodide build
IvanIsCoding 8c4ed7b
Add GitHub Actions to execute
IvanIsCoding d99c029
Fix main.yml syntax
IvanIsCoding 615d5bd
Specify pyproject.toml
IvanIsCoding 32e44cf
Actually download repo
IvanIsCoding ad1f19d
Add pyodide build docs
IvanIsCoding 901c674
Minor stuff
IvanIsCoding 92b8910
Minor update to CONTRIBUTING.md
IvanIsCoding 826fbe7
Merge branch 'main' into pyodide-rayon
IvanIsCoding 61383bf
Merge branch 'pyodide-rayon' into pixi-pyodide
IvanIsCoding b6fcd9a
Merge branch 'main' into pyodide-rayon
IvanIsCoding aa34512
Solve nit
IvanIsCoding 854e672
Merge branch 'pyodide-rayon' into pixi-pyodide
IvanIsCoding 1a04b00
Merge branch 'main' into pyodide-rayon
IvanIsCoding b0042ff
Merge branch 'pyodide-rayon' into pixi-pyodide
IvanIsCoding d7bb215
Bump pyodide to 0.27.6 and pyodide-build to 0.30.4
IvanIsCoding 5378a9e
Merge branch 'main' into pyodide-rayon
IvanIsCoding cea6073
Merge remote-tracking branch 'origin/pyodide-rayon' into pixi-pyodide
IvanIsCoding 6b8b8fc
Merge branch 'main' into pixi-pyodide
IvanIsCoding 1a188e4
Merge branch 'main' into pixi-pyodide
IvanIsCoding 24f000c
Update pyodide build & pyodide
IvanIsCoding ce94f8e
Merge remote-tracking branch 'upstream/main' into pixi-pyodide
IvanIsCoding 281fae3
Merge branch 'main' into pixi-pyodide
IvanIsCoding 74c65db
Merge branch 'main' into pixi-pyodide
IvanIsCoding fb02e0a
Merge branch 'main' into pixi-pyodide
IvanIsCoding 618a669
Bump emscripten and Pyodide
IvanIsCoding 71f03f8
Bump pixi
IvanIsCoding 0884ce4
Refresh lock file to fix failure
IvanIsCoding c7af71a
Try to align Rust version with pyodide recipes
IvanIsCoding b3f4d2a
Revert to Pyodide 0.27.7 with emscripten 3.1.58
IvanIsCoding 54d64b0
Merge branch 'main' into pixi-pyodide
IvanIsCoding 52bdafc
Merge remote-tracking branch 'upstream/main' into pixi-pyodide
IvanIsCoding a4c1b21
Smaller diff now that pixi understands TOML better
IvanIsCoding cb9e76f
Fix toml
IvanIsCoding bdbee5b
Merge remote-tracking branch 'upstream/main' into pixi-pyodide
IvanIsCoding c25dec2
Merge branch 'main' into pixi-pyodide
IvanIsCoding 1ceb2be
Merge branch 'main' into pixi-pyodide
mtreinish 3406ff3
Merge branch 'main' into pixi-pyodide
IvanIsCoding 7a4d3ed
Merge remote-tracking branch 'upstream/main' into pixi-pyodide
IvanIsCoding 2c6f706
Update CONTRIBUTING.md
IvanIsCoding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,4 @@ | ||
| docs/* linguist-documentation | ||
| releasenotes/* linguist-documentation | ||
| # SCM syntax highlighting & preventing 3-way merges | ||
| pixi.lock merge=binary linguist-language=YAML linguist-generated=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run this locally I first got an issue about the
emcc -vcall failing, when I set the env var to skip the version check it errors during the build with:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I have not been able to reproduce this. I tested on Linux locally, Mac locally, and on CI.
If you tell me the workaround you used, I can add it to
pyproject.tomlor at least mention it inCONTRIBUTING.md