Add assertion-based matplotlib tests for mpl_draw#1562
Add assertion-based matplotlib tests for mpl_draw#1562Rachel-Eva wants to merge 6 commits intoQiskit:mainfrom
Conversation
|
|
|
I will take a look at this more carefully later. But first things first: thanks for getting this started! |
Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
|
@Rachel-Eva this LGTM but you need to sign the CLA before I am able to merge. The email used for the commits also indicates another user: @kasryan. So either sign with that account or rewrite the commits to use a new email associated with your current account. |
|
Hi, I've been trying to rewrite the commits but ran into issues with the rebase. The commits attributed to @kasryan are mine, that account somehow got linked to my git config. Is there any way to resolve this on your end, or would it be easier if I close this PR and open a fresh one with the correct author info? |
You can also edit the commits to update the email. And then do a force push. https://stackoverflow.com/questions/1186535/how-do-i-modify-a-specific-commit As long as the CLA check pass you are fine. Up to you if you want a new PR or rewrite the PR. |
|
Hi @IvanIsCoding, I ran into some git history issues trying to rewrite the commits so I've opened a new PR #1567 with the correct author info. |
Fixes #1316
Adds a new
TestMPLDrawAssertionstest class that asserts actualproperties of the matplotlib output rather than just checking that
drawing doesn't crash. Tests are Linux-only as suggested by the
maintainer.
New tests cover:
Node count reflected in collections
node_listfilteringNode color applied
Node labels drawn as text
Edge count
Directed graphs produce arrow patches
Edge labels drawn as text
node_size=0produces zero-size collectionEmpty graph produces no collections
I ran rustfmt locally
I have added the tests to cover my changes.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.