Skip to content

feat(argocd): design prototype#2531

Draft
TheoGrandin74 wants to merge 13 commits intonew-navigationfrom
design/argo-cd
Draft

feat(argocd): design prototype#2531
TheoGrandin74 wants to merge 13 commits intonew-navigationfrom
design/argo-cd

Conversation

@TheoGrandin74
Copy link
Copy Markdown
Contributor

Summary

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Copy Markdown
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Help yourself at 2AM by putting some metrics to help observability

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 62.16814% with 171 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@91c594a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...d-integration/argocd-associated-services-modal.tsx 7.50% 37 Missing ⚠️
...argocd-integration/settings-argocd-integration.tsx 81.06% 24 Missing and 8 partials ⚠️
...ment-action-toolbar/environment-action-toolbar.tsx 20.51% 30 Missing and 1 partial ⚠️
...ttings-argocd-integration/connect-argocd-modal.tsx 52.63% 17 Missing and 1 partial ⚠️
...ices/feature/src/lib/service-list/service-list.tsx 68.57% 9 Missing and 2 partials ⚠️
...s-argocd-integration/link-qovery-cluster-modal.tsx 55.00% 9 Missing ⚠️
...-table/environment-section/environment-section.tsx 58.33% 0 Missing and 5 partials ⚠️
...ature/src/lib/fake-argocd-mode/fake-argocd-mode.ts 80.00% 1 Missing and 3 partials ⚠️
...iew-environments/settings-preview-environments.tsx 0.00% 4 Missing ⚠️
...eature/src/lib/service-actions/service-actions.tsx 20.00% 2 Missing and 2 partials ⚠️
... and 6 more
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2531   +/-   ##
=================================================
  Coverage                  ?   45.37%           
=================================================
  Files                     ?     1073           
  Lines                     ?    21817           
  Branches                  ?     6420           
=================================================
  Hits                      ?     9899           
  Misses                    ?    10144           
  Partials                  ?     1774           
Flag Coverage Δ
unittests 45.37% <62.16%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd added the V5 label Mar 24, 2026
@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Mar 24, 2026

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants