Skip to content

fix(variable-list): replace service type by Service label#2561

Merged
rmnbrd merged 2 commits intonew-navigationfrom
feat/new-nav/variables-ui
Apr 1, 2026
Merged

fix(variable-list): replace service type by Service label#2561
rmnbrd merged 2 commits intonew-navigationfrom
feat/new-nav/variables-ui

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Mar 31, 2026

Summary

  • Display "Service" instead of serviceType

https://qovery.slack.com/archives/C0AML0VDUV8/p1774360937540619

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet added the V5 label Mar 31, 2026
@RemiBonnet RemiBonnet marked this pull request as ready for review March 31, 2026 15:08
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.74%. Comparing base (c4d645a) to head (498f281).
⚠️ Report is 2 commits behind head on new-navigation.

Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2561      +/-   ##
==================================================
- Coverage           45.49%   44.74%   -0.76%     
==================================================
  Files                1116      636     -480     
  Lines               22298    14834    -7464     
  Branches             6530     4377    -2153     
==================================================
- Hits                10145     6637    -3508     
+ Misses              10296     7012    -3284     
+ Partials             1857     1185     -672     
Flag Coverage Δ
unittests 44.74% <100.00%> (-0.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@rmnbrd rmnbrd merged commit 9d43735 into new-navigation Apr 1, 2026
10 of 11 checks passed
@rmnbrd rmnbrd deleted the feat/new-nav/variables-ui branch April 1, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants