-
Notifications
You must be signed in to change notification settings - Fork 31
feat(envs): add bulk stop action #2741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rmnbrd
wants to merge
3
commits into
staging
Choose a base branch
from
feat/envs/bulk-stop
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
135 changes: 135 additions & 0 deletions
135
...ns/environments/feature/src/lib/environments-table/environments-table-action-bar.spec.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| import { EnvironmentModeEnum, type EnvironmentOverviewResponse } from 'qovery-typescript-axios' | ||
| import { renderWithProviders, screen } from '@qovery/shared/util-tests' | ||
| import { EnvironmentsTableActionBar } from './environments-table-action-bar' | ||
|
|
||
| const mockStopEnvironment = jest.fn() | ||
| const mockOpenModalConfirmation = jest.fn() | ||
|
|
||
| jest.mock('@qovery/shared/ui', () => ({ | ||
| ...jest.requireActual('@qovery/shared/ui'), | ||
| useModalConfirmation: () => ({ | ||
| openModalConfirmation: mockOpenModalConfirmation, | ||
| }), | ||
| })) | ||
|
|
||
| jest.mock('../hooks/use-stop-environment/use-stop-environment', () => ({ | ||
| useStopEnvironment: () => ({ | ||
| mutateAsync: mockStopEnvironment, | ||
| }), | ||
| })) | ||
|
|
||
| const rows: EnvironmentOverviewResponse[] = [ | ||
| { | ||
| id: 'env-1', | ||
| name: 'Stoppable environment', | ||
| mode: EnvironmentModeEnum.DEVELOPMENT, | ||
| services_overview: { | ||
| service_count: 2, | ||
| managed_by: 'QOVERY', | ||
| }, | ||
| deployment_status: { | ||
| last_deployment_state: 'DEPLOYED', | ||
| }, | ||
| }, | ||
| { | ||
| id: 'env-2', | ||
| name: 'Stopped environment', | ||
| mode: EnvironmentModeEnum.DEVELOPMENT, | ||
| services_overview: { | ||
| service_count: 2, | ||
| managed_by: 'QOVERY', | ||
| }, | ||
| deployment_status: { | ||
| last_deployment_state: 'STOPPED', | ||
| }, | ||
| }, | ||
| ] as EnvironmentOverviewResponse[] | ||
|
|
||
| describe('EnvironmentsTableActionBar', () => { | ||
| beforeEach(() => { | ||
| mockStopEnvironment.mockReset() | ||
| mockOpenModalConfirmation.mockReset() | ||
| mockStopEnvironment.mockResolvedValue(undefined) | ||
| }) | ||
|
|
||
| it('should render successfully', () => { | ||
| const { baseElement } = renderWithProviders( | ||
| <EnvironmentsTableActionBar projectId="project-1" selectedRows={[]} resetRowSelection={jest.fn()} /> | ||
| ) | ||
| expect(baseElement).toBeTruthy() | ||
| }) | ||
|
|
||
| it('should show selected environment count', () => { | ||
| renderWithProviders( | ||
| <EnvironmentsTableActionBar projectId="project-1" selectedRows={rows} resetRowSelection={jest.fn()} /> | ||
| ) | ||
|
|
||
| expect(screen.getByText('2 selected environments')).toBeInTheDocument() | ||
| }) | ||
|
|
||
| it('should disable stop action when no selected environment can be stopped', async () => { | ||
| const { userEvent } = renderWithProviders( | ||
| <EnvironmentsTableActionBar projectId="project-1" selectedRows={[rows[1]]} resetRowSelection={jest.fn()} /> | ||
| ) | ||
|
|
||
| await userEvent.click(screen.getByRole('button', { name: /more/i })) | ||
|
|
||
| const stopSelectedItem = screen.getByText('Stop selected') | ||
| expect(stopSelectedItem.closest('[role="menuitem"]')).toHaveAttribute('aria-disabled', 'true') | ||
|
|
||
| expect(mockOpenModalConfirmation).not.toHaveBeenCalled() | ||
| }) | ||
|
|
||
| it('should confirm and stop only stoppable selected environments', async () => { | ||
| const resetRowSelection = jest.fn() | ||
| const selectedRows = [ | ||
| ...rows, | ||
| { | ||
| id: 'env-3', | ||
| name: 'Restarted environment', | ||
| mode: EnvironmentModeEnum.DEVELOPMENT, | ||
| services_overview: { | ||
| service_count: 2, | ||
| managed_by: 'QOVERY', | ||
| }, | ||
| deployment_status: { | ||
| last_deployment_state: 'RESTARTED', | ||
| }, | ||
| }, | ||
| ] as EnvironmentOverviewResponse[] | ||
|
|
||
| const { userEvent } = renderWithProviders( | ||
| <EnvironmentsTableActionBar | ||
| projectId="project-1" | ||
| selectedRows={selectedRows} | ||
| resetRowSelection={resetRowSelection} | ||
| /> | ||
| ) | ||
|
|
||
| await userEvent.click(screen.getByRole('button', { name: /more/i })) | ||
| await userEvent.click(screen.getByText('Stop selected')) | ||
|
|
||
| expect(mockOpenModalConfirmation).toHaveBeenCalledWith( | ||
| expect.objectContaining({ | ||
| title: 'Confirm stop', | ||
| confirmationMethod: 'action', | ||
| confirmationAction: 'stop', | ||
| }) | ||
| ) | ||
|
|
||
| const modalProps = mockOpenModalConfirmation.mock.calls[0][0] | ||
| renderWithProviders(modalProps.description) | ||
| expect(screen.getByText(/You are going to stop 2 environments/)).toBeInTheDocument() | ||
|
|
||
| renderWithProviders(modalProps.warning) | ||
| expect(screen.getByText('Some environments will not be impacted:')).toBeInTheDocument() | ||
| expect(screen.getByText('Stopped environment')).toBeInTheDocument() | ||
|
|
||
| await modalProps.action() | ||
|
|
||
| expect(mockStopEnvironment).toHaveBeenCalledTimes(2) | ||
| expect(mockStopEnvironment).toHaveBeenCalledWith({ environmentId: 'env-1' }) | ||
| expect(mockStopEnvironment).toHaveBeenCalledWith({ environmentId: 'env-3' }) | ||
| expect(resetRowSelection).toHaveBeenCalledTimes(1) | ||
| }) | ||
| }) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.