Skip to content

feat(argocd): add GET /argocdApp/{id}/manifest endpoint#1095

Merged
fabienfleureau merged 3 commits into
mainfrom
QOV-1659-argocd-app-manifest
May 13, 2026
Merged

feat(argocd): add GET /argocdApp/{id}/manifest endpoint#1095
fabienfleureau merged 3 commits into
mainfrom
QOV-1659-argocd-app-manifest

Conversation

@fabienfleureau
Copy link
Copy Markdown
Contributor

Summary

  • Add GET /argocdApp/{argocdAppId}/manifest endpoint returning manifest enrichment data
  • Add ArgocdAppManifestResponse schema with manifest_revision and manifest_metadata (contains managed_resources array)
  • Add ArgocdManagedResource schema with kind, name, namespace, targetState, liveState

Test plan

  • Schema validates (YAML is well-formed)
  • New path and schemas visible in generated API docs

Copilot AI review requested due to automatic review settings May 12, 2026 14:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new ArgoCD API surface to retrieve “manifest enrichment” data for an ArgoCD app, and aligns websocket service typing with existing service types.

Changes:

  • Added GET /argocdApp/{argocdAppId}/manifest returning ArgocdAppManifestResponse.
  • Introduced ArgocdAppManifestResponse and ArgocdManagedResource schemas for managed resource metadata and states.
  • Extended websocket ServiceType enum with ARGOCD_APP.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
openapi.yaml Adds the new ArgoCD manifest endpoint and its response/resource schemas.
websocket/websocket-openapi.yaml Adds ARGOCD_APP to the websocket ServiceType enum.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread openapi.yaml
Comment thread openapi.yaml
Comment thread openapi.yaml
@fabienfleureau fabienfleureau force-pushed the QOV-1659-argocd-app-manifest branch from 9949e3c to 4b5742b Compare May 13, 2026 10:52
@fabienfleureau fabienfleureau merged commit b58769b into main May 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants