Update SciPy lecture: Fix outdated import statement for SciPy 1.15+ compatibility#406
Merged
Update SciPy lecture: Fix outdated import statement for SciPy 1.15+ compatibility#406
Conversation
…ompatibility Co-authored-by: mmcky <8263752+mmcky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update SciPy lecture for version 1.15
Update SciPy lecture: Fix outdated import statement for SciPy 1.15+ compatibility
Aug 28, 2025
Contributor
|
Contributor
|
This review triggers some good ideas, but copilot didn't interpret the context of the lecture correctly. I have made a manual update to this PR to address the good review suggestion -- and made a note about older versions of SciPy |
Contributor
|
@bishmaybarik when you have time would you mind to review this suggestion? |
Member
Hi @mmcky. Sure, I'll review this and get back to you as soon as possible! |
bishmaybarik
approved these changes
Aug 29, 2025
Member
bishmaybarik
left a comment
There was a problem hiding this comment.
Hi @mmcky , I went through the PR and this version looks good. I also checked the deployment and it looks like everything is clear and in place.
Contributor
|
thanks @bishmaybarik. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SciPy lecture contained an outdated example showing that importing SciPy automatically imports NumPy symbols into the global namespace. This behavior changed in modern SciPy versions (1.15+) as part of namespace cleanup efforts.
What was wrong:
The lecture showed this outdated code example:
What's fixed:
Updated the section to accurately reflect that SciPy 1.15+ no longer auto-imports NumPy symbols, which is better practice as it avoids namespace pollution. The lecture now correctly explains that NumPy should be imported explicitly:
Testing:
scipy.stats,scipy.optimize, andscipy.integratemodulesThis change ensures students learn current best practices while maintaining full compatibility with modern SciPy versions.
Fixes #334.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fred.stlouisfed.org/usr/share/miniconda/envs/quantecon/bin/python -Xfrozen_modules=off -m ipykernel_launcher -f /tmp/tmpvqpmxghl.json --HistoryManager.hist_file=:memory:(dns block)https://api.github.com/repos/scipy/scipy/releases/tags/v1.15.0curl -s REDACTED(http block)jax.quantecon.org/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures --path-output ./ -n -W --keep-going(dns block)/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures/scipy.md --path-output ./ -n -W --keep-going(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.