obs: Add Prometheus metrics endpoint for request counting and latency#161
Merged
Merged
Conversation
- Add prometheus-client==0.21.1 dependency - Add PrometheusMiddleware tracking http_requests_total, http_request_duration_seconds, http_requests_in_flight - Expose /metrics endpoint Closes Quantarq#82
Contributor
|
Hi @amberly-d — the implementation looks great; the middleware, /metrics endpoint, and histogram labels are well thought out. CI is failing at the install step though, because
Quick fix: run |
Contributor
|
@amberly-d resolve conflicts |
…rics-82 # Conflicts: # quantara/poetry.lock # quantara/pyproject.toml
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Prometheus metrics instrumentation to the FastAPI backend: a middleware that tracks request count, latency histograms, and in-flight gauge, plus a
/metricsendpoint exposing data in Prometheus text format.Related Issue
Closes #82
Change Type
Testing Done
153 unit tests pass. All failures are pre-existing DB connectivity issues unrelated to these changes.
Checklist
pytest)pylint)