Open
Conversation
Merging this PR will degrade performance by 15.17%
Performance Changes
Comparing |
defe585 to
c1b7268
Compare
Collaborator
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
6bce5f3 to
f320844
Compare
Collaborator
Author
|
The changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #282.
We partially implemented generic node/port/portOffset parameters for some portgraph containers, but
NodeMetaandPortMetastill were stuck hardcoding the types.This change ensures everything is generic.
Unsigned::NonZeroassociated type so we can have niche optimization with arbitrary indices.<N=u32, P=u32>. I'll check if we can actually make the blanket impl next.This may be a breaking change due to the new
Unsigned::NonZero. I would hope users are not implementing that trait, but we forgot to seal it so we may need to mark this as breaking :/