Skip to content

Scope writing context and verify document builds - #72

Merged
GiggleLiu merged 2 commits into
mainfrom
improve/scoped-writing-workflow
Sep 23, 2026
Merged

GiggleLiu merged 2 commits into
mainfrom
improve/scoped-writing-workflow

Conversation

@nzy1997

@nzy1997 nzy1997 commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Shared writing guidance could load unrelated context, apply blanket word-count/connective rules, or report a clean build when the compiler failed without printing the word warning. This PR scopes source loading to the requested evidence, preserves meaningful scientific contrasts, and makes the documented Typst check honor both compiler exit status and diagnostics.

The change follows OpenAI's Rethinking skills and prompts for GPT-6 Astra: keep shared rules narrow, preserve user intent, and define a verifiable completion condition. It is the shared-writing slice split from #62 after review feedback.

Validation

  • python3 scripts/validate_skills.py: 16 skills pass
  • targeted writing/repository tests: 60 passed
  • python3 -m pytest -q: 272 passed, 5 skipped
  • the build regression covers clean output, warnings, non-warning compiler errors, and an unavailable compiler, including temporary-log cleanup
  • git diff --check: clean

Drop the style-guide and checklist rule changes, the drafting-mode change,
the recency-gate removal, and the output-format default change; those are
separate decisions. Keep the shared "Installed resources" block identical
across skills. Rewrite the Typst check without `exit` so it is safe to paste
into an interactive shell; it still fails on a nonzero exit or any warning.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@GiggleLiu

Copy link
Copy Markdown
Member

Narrowed on top of your commit (3bb1c65) to the two things the title promises: context scoping in writing-workflow.md and the compile-check fix (which was a real bug — a failed compiler with no "warning" text printed "clean"). Dropped from this PR: the how-to-technical-writing guardrail and checklist rule changes (sentence-length band, "X not Y", notation table, inline calculations), the whole-report drafting mode, the recency-gate removal, and the Markdown output default. Those change rules merged in #60 and belong in their own PR if wanted. The check snippet no longer uses exit, so it is safe to paste into an interactive shell; your test still passes against it.

@GiggleLiu
GiggleLiu merged commit b4836ff into main Sep 23, 2026
1 check passed
@GiggleLiu
GiggleLiu deleted the improve/scoped-writing-workflow branch September 23, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants