Skip to content

Small lints #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OttoHatt wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Small lints #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d43437
fix: replace deprecated 'toHsv' with 'ToHsv'
OttoHatt Sep 23, 2023
a070456
fix: Duplicate 'ObservableMapList:GetListForKey'
OttoHatt Sep 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/color3utils/src/Shared/Color3Utils.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ end
@return Color3
]=]
function Color3Utils.scaleValue(color3, percent)
local h, s, v = Color3.toHSV(color3)
local h, s, v = color3:ToHsv()
return Color3.fromHSV(h, s, percent*v)
end

Expand All @@ -60,7 +60,7 @@ end
@return Color3
]=]
function Color3Utils.setValue(color3, value)
local h, s, _ = Color3.toHSV(color3)
local h, s, _ = color3:ToHsv()
return Color3.fromHSV(h, s, value)
end

Expand All @@ -71,7 +71,7 @@ end
@return Color3
]=]
function Color3Utils.setHue(color3, hue)
local _, s, v = Color3.toHSV(color3)
local _, s, v = color3:ToHsv()
return Color3.fromHSV(hue, s, v)
end

Expand All @@ -82,7 +82,7 @@ end
@return Color3
]=]
function Color3Utils.scaleSaturation(color3, percent)
local h, s, v = Color3.toHSV(color3)
local h, s, v = color3:ToHsv()
return Color3.fromHSV(h, percent*s, v)
end

Expand All @@ -93,7 +93,7 @@ end
@return Color3
]=]
function Color3Utils.setSaturation(color3, saturation)
local h, _, v = Color3.toHSV(color3)
local h, _, v = color3:ToHsv()
return Color3.fromHSV(h, saturation, v)
end

Expand Down
17 changes: 0 additions & 17 deletions src/observablecollection/src/Shared/ObservableMapList.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,23 +198,6 @@ function ObservableMapList:ObserveItemsForKeyBrio(key)
})
end

--[=[
Gets a list for a given key.

@param key TKey
@return { TValue }
]=]
function ObservableMapList:GetListForKey(key)
assert(key ~= nil, "Bad key")

local observableList = self:GetListForKey(key)
if not observableList then
return {}
end

return observableList:GetList()
end

--[=[
Gets the observable list for the given key
@param key TKey
Expand Down