You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(storage): a secure-store read error becomes an empty password, and the next edit can erase the stored one #1303
ConnectionSecretsStore.readForConnection and readSshSecretsForConnection (lib/core/storage/connection_secrets_store.dart) catch every error and return nulls. Callers cannot tell no secret from the store did not answer (libsecret / Keychain locked, no keyring daemon on Linux).
Consequences:
Misleading error. The drivers (postgres_connection.dart, mysql_connection.dart, redis_connection.dart, mongodb_connection.dart) also wrap the read in catch (_) {} and connect with no password. The user sees Authentication failed. Check the username and password and goes to retype a correct password, when the real problem is the keyring.
Possible erasure.LocalDb.updateConnection reads the previous secrets with the same call, and mergeSecretsForConnectionUpdate merges blank fields from it. If a failed read returns null, the next write stores null, which _FlutterSecureStorageBackend.write turns into a delete: the saved password is gone after an unrelated edit (a rename).
Scope
Distinguish absent from unreadable: the read throws (or returns a result type) on a store error.
Connect paths surface it as its own error: Could not read the saved password from the system keyring with a hint (unlock the keyring / start the secret service), not as an authentication failure.
updateConnection and the secret merge abort without writing when the previous secrets could not be read.
Acceptance
A backend whose read throws makes a connect fail with a keyring error, not Authentication failed.
Editing a connection while the store cannot be read does not delete the stored password.
Reading an absent key still returns null without an error.
Activity
Merge pull request #1320 from QueryaHub/fix/1303-secret-store-read-er…
ZhuchkaTriplesix commentedon Oct 10, 2026
Сделано в #1320, смержено в dev.