Skip to content

ui(theme): fix invisible swatch border in dark themes and add mono fallback to Theme Studio #1654

Closed

Description

@ZhuchkaTriplesix

Problem

  1. In lib/features/settings/theme_preview_card.dart (_Swatch, lines 225–227):
    border: material.Border.all(
      color: material.Colors.black.withValues(alpha: 0.12),
    ),
    A semi-transparent black border is used around color swatches. In dark themes (Dark, Tokyo Night, Monokai, Dracula), dark swatch colors (such as background #1e1e1e or surface #18181b) have zero border contrast against dark popover backgrounds, making swatch boundaries invisible.
  2. In lib/features/settings/theme_editor_dialog.dart (_ThemeEditorColorRow, line 346):
    style: material.TextStyle(
      fontSize: 12,
      color: cs.mutedForeground,
      fontFamily: QueryaTypography.mono,
    ),
    The hex code displays with QueryaTypography.mono but omits fontFamilyFallback: QueryaTypography.monoFontFamilyFallback.

Solution

  • Use Theme.of(context).colorScheme.border or context.workbench.borderSubtle for swatch borders so they adapt properly in both light and dark themes.
  • Provide fontFamilyFallback: QueryaTypography.monoFontFamilyFallback in _ThemeEditorColorRow.

Activity

  1. added
    bugSomething isn't working
    themeTheming, colors, VS Code themes
    frontendTheme parser epic label: frontend
    settingsTheme parser epic label: settings
    on Oct 17, 2026
  2. added this to the Theme system milestone on Oct 17, 2026
  3. added a commit that references this issue on Oct 17, 2026
  4. ZhuchkaTriplesix commented on Oct 17, 2026

    @ZhuchkaTriplesix
    MemberAuthor

    Resolved via PR #1655.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingfrontendTheme parser epic label: frontendsettingsTheme parser epic label: settingsthemeTheming, colors, VS Code themes

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions