Skip to content

ux(connections): a failed save of a new connection discards everything the user typed #1758

Closed

Description

@ZhuchkaTriplesix

Problem

The creation flows (`promptCreateConnection`, `showNewConnectionUrlDialog`, `showSqliteConnectionForm`) close their dialog and return a `ConnectionRow`; the caller saves it afterwards (`saveNewConnection`, #1757). When the save fails (typically the system keyring refusing the password, seen on macOS), the row is rolled back and the user gets a toast, but the form is already gone. A long form (host, SSH tunnel, certificates, password) has to be typed again to retry.

Proposal

Keep the form open until the save succeeded: either save inside the dialog flow (show the error in the form and let the user press Save again), or reopen the form prefilled with the returned row on failure.

Where

  • `lib/features/connections/connection_creation_flow.dart` (`saveNewConnection`, `promptCreateConnection`)
  • `lib/features/main_screen/main_screen_dialogs.dart`, `lib/features/connections/connections_panel.dart` (callers)

Found in the review of #1757.

Activity

  1. added
    bugSomething isn't working
    connectionsDatabase connections, URI parsing, pools
    uxUser experience, keyboard shortcuts and interactions
    P2Medium priority / Parity & Refactoring
    on Oct 25, 2026
  2. added a commit that references this issue on Oct 25, 2026
  3. ZhuchkaTriplesix commented on Oct 25, 2026

    @ZhuchkaTriplesix
    MemberAuthor

    Fixed on dev (#1808 for the rest of #1776 after #1802; #1809 for #1758). Closing by hand: the PRs target dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium priority / Parity & RefactoringbugSomething isn't workingconnectionsDatabase connections, URI parsing, poolsuxUser experience, keyboard shortcuts and interactions

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions