Repository navigation
ci: pin Flutter 3.47.1 so Linux releases ship the 120 Hz engine - #1246
Merged
Merged
Conversation
apply_patched_engine.sh looks up a patched libflutter_linux_gtk.so by the engine content hash. The only published build (engine-11d79658...) is for Flutter 3.47.1, while CI and release pinned 3.41.6 (content hash 5cdd3277...). Release 0.4.18 therefore shipped the stock engine, capped at 60 fps. The dev container stays on 3.41.6: cirruslabs/flutter has no 3.47.1 image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #980
Problem
scripts/linux/apply_patched_engine.shdownloads the vsync-patchedlibflutter_linux_gtk.sofromQueryaHub/flutter-engine-linux-120hzby the engine content hash. The only published build,engine-11d79658c444477b06513d32b52c8c4ccb7276b0, is for Flutter 3.47.1. CI and release pinned 3.41.6, whose content hash is5cdd32777948fa7a648fac915f8da7120ac7e97a.The 0.4.18 release log shows the result:
Change
flutter-version: '3.47.1'inci.yml(3 jobs),release.yml(4 jobs) andbenchmark.yml.docs/motion-and-high-refresh.md: toolchain line updated.Not changed
.devcontainer/Dockerfile(and its line indocs/ci-runners.md) stays on 3.41.6:ghcr.io/cirruslabs/flutterhas no 3.47.1 image yet (newest tag 3.44.0).How to check
spliced in vsync-patched engine for content hash 11d79658…instead of the warning.