Repository navigation
test(erd): close the acceptance gaps of #1153, #1155 and #1157 - #1247
Merged
Merged
Conversation
- #1157: the empty search result uses the UI kit text, not a raw Text; a search that matches nothing is covered. - #1153: SVG text is checked against the card width, using the same glyph estimate the export cuts with. - #1155: double click on a table of another schema opens it by its qualified name.
github-actions
Bot
added
bug
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1153
Closes #1157
Refs #1155
Changes
Text(...).muted().small()from the UI kit instead of a rawmaterial.Text. A test checks that a search with no match says so.sales.ordersopens it by its qualified name. The name-to-object step is already tested inerd_table_names_test.dart.Not covered (#1155 stays open)
The end-to-end path (double click → table browser on a non-default schema in the workspace) has no widget test yet.