Repository navigation
test: close the debt of #1162, #1164 and #1165 - #1249
Merged
Merged
Conversation
- #1162: the guard missed two results files pulled in by the results tab (filter bar and value panel). Their Material icon buttons now use QueryaIconButton, and the guard scans both files. - #1164: MySQL three-table join and SQLite three-step plan on recorded output: tree shape, per-table cost, highlighted table, estimates. - #1165: the stats history recorder is a function, tested for the first and second poll, a restart and missing counts; sparkline tooltip tests for the newest sample.
Grid scroll benchmark
Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result. |
Grid scroll benchmark
Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1162
Closes #1164
Refs #1165
Changes
data_grid_filter_bar.dartanddata_grid_value_panel.dart, still used Material icon buttons. They now useQueryaIconButton(dense), and the guard scans them. The MQL console (mongo_query_workspace.dart) was already in the guard.recordServerStats, which is tested for the first and second poll, a restart, missing databases and missing counts. Sparkline widget tests cover the tooltip before the first sample, the newest value, whole numbers and a flat series.Not covered (#1165 stays open)
PostgresServiceis a singleton with no seam, so that test is not written.ticker_gated_polling_test.dart, not by a test of this view.