Skip to content

test: close the debt of #1162, #1164 and #1165 - #1249

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
test/1165-1164-1162-debt
Oct 9, 2026
Merged

ZhuchkaTriplesix merged 2 commits into
devfrom
test/1165-1164-1162-debt

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Closes #1162
Closes #1164
Refs #1165

Changes

Not covered (#1165 stays open)

  • "No extra queries per poll" needs a counting fake service. PostgresService is a singleton with no seam, so that test is not written.
  • Polling stopping when Overview is hidden is covered by ticker_gated_polling_test.dart, not by a test of this view.

- #1162: the guard missed two results files pulled in by the results tab
  (filter bar and value panel). Their Material icon buttons now use
  QueryaIconButton, and the guard scans both files.
- #1164: MySQL three-table join and SQLite three-step plan on recorded
  output: tree shape, per-table cost, highlighted table, estimates.
- #1165: the stats history recorder is a function, tested for the first
  and second poll, a restart and missing counts; sparkline tooltip tests
  for the newest sample.
@github-actions github-actions Bot added enhancement New feature or request editor Code/SQL editor frontend Theme parser epic label: frontend ui User interface components and widgets data-grid Interactive data grid, cell editor, filtering, groupings P2 Medium priority / Parity & Refactoring P3 Low priority / Polish & Enhancements labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Grid scroll benchmark

metric base PR change
p50 42.20 ms 42.37 ms +0.4%
p90 51.28 ms 51.15 ms -0.3%
p99 63.82 ms 69.07 ms +8.2% ⚠️
stutters 223.00 222.00 -0.4%

Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result.

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 7619e32 into dev Oct 9, 2026
14 checks passed
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Grid scroll benchmark

metric base PR change
p50 42.38 ms 42.18 ms -0.5%
p90 50.56 ms 50.94 ms +0.8%
p99 61.64 ms 65.58 ms +6.4% ⚠️
stutters 230.00 226.00 -1.7%

Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data-grid Interactive data grid, cell editor, filtering, groupings editor Code/SQL editor enhancement New feature or request frontend Theme parser epic label: frontend P2 Medium priority / Parity & Refactoring P3 Low priority / Polish & Enhancements ui User interface components and widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant