Repository navigation
refactor(motion): Redis scroll and chevron animations use QueryaMotion tokens (#1240) - #1259
Merged
Merged
Conversation
…yaMotion tokens The CLI scrolls to the newest output with the fast token and the enter curve, and jumps when reduced motion makes the duration zero (animateTo needs a non-zero duration). The key folder chevron rotates with the tree expand token and curve, like the other tree chevrons.
github-actions
Bot
added
performance
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redis_cli_workspace.dart):context.motionDuration(QueryaMotion.fast)andcontext.motionCurve(QueryaMotion.enter)replaceDuration(milliseconds: 150)/Curves.easeOut. When reduced motion makes the duration zero, itjumpTos the end:animateToasserts a non-zero duration. It also checksmountedin the post-frame callback.redis_keys_view.dart):QueryaMotion.treeExpand/treeExpandCurve, like the chevrons in the connection tree.No other bare
duration:/Curves.remains inlib/features. Outside it: the update badge's pulse period is a named constant, and the popover timings inapp/app.dartare configured above the motion scope; both left as they are.Closes #1240
Test plan