Repository navigation
refactor(erd): extract notes from ErdView (part of #1362) - #1394
Merged
Merged
Conversation
- ErdNoteCard: the sticky note widget with its menu and resize handle - ErdNoteOps: pure id, placement, drag, resize and nearest-table rules, covered by unit tests without a widget tester
github-actions
Bot
added
frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1362 (second step; the issue stays open until
erd_view.dartis a thin coordinator).What this PR does
ErdNoteCard(lib/features/erd/widgets/erd_note_card.dart): the sticky note widget, its context menu and resize handle. Changes go out through callbacks.ErdNoteOps(lib/core/erd/erd_note_ops.dart): pure id, placement, drag, resize and nearest-table rules.test/core/erd/erd_note_ops_test.dart: unit tests without a widget tester.erd_view.dartkeeps the thin wrappers and the state; no behaviour change intended (1950 -> ~1780 lines).Still on #1362
Canvas gestures / zoom (
ErdCanvas), selection and search state (ErdViewController), and the PNG/SVG/PDF export operations.Not run locally; CI is the check.