Repository navigation
refactor(ui): QueryaIconButton is a thin wrapper over QueryaButton - #1471
Merged
Merged
Conversation
One icon-button system: same states, ring and semantics as every other button, no Material InkWell path. The color / activeColor parameters go; the call sites that used a colour as a toggled look pass isActive. Refs #1440
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1440.
QueryaIconButton(MaterialInkWell, its own hover and ripple) andQueryaButton.icon(the standard's states) sat next to each other and reacted differently.QueryaIconButtonis now aStatelessWidgetthat renders a ghost, icon-onlyQueryaButton:isActive->isActive,isDestructive-> destructive tone,sizeandborderRadiuspass through; the tooltip is also the spoken label;iconis anIcon(all 27 call sites already were): its glyph is used, size and colour come from the control size and the button's state;color/activeColorare removed. 14 call sites usedcolor: mutedForegroundfor a quiet look (dropped) or a colour as a toggled state (results toolbar: nowisActive);selectedsemantics come fromQueryaButton.Tests: the size tests measure the widget, the focus-ring test is replaced by a mapping test (variant, tone, active, tooltip), the disabled test checks
onPressed.QueryaToolbarButton(labelled, still Material) is left for the remaining buttons clean-up (#1445).