Repository navigation
fix(sql-workspace): Run on an empty editor says so; status bar follows the active tab - #1481
Merged
Merged
Conversation
…llows the active tab Run / Explain with nothing to run show 'Nothing to run' instead of silence. The status bar shows the active tab's own message, row and column counts and time, and nothing for a tab that has not run. A plain 'N row(s).' is no longer repeated in the status bar (the result bar and the counts on its right already show it). Fixes #1478, fixes #1479
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1478 and #1479.
#1478, Run on an empty editor
Nothing to runinstead of doing nothing; Explain saysNothing to explain.#1479, status bar
buildpublishes them when the active session changes; it does nothing while a query is running).N row(s).is not repeated in the status bar: the result bar shows it and the status bar's right side has theN rows, M cols. Errors,Statement 3 of 5 failed…,OK. Rows affected: …and capped-result messages stay.QueryaShellStatus.setQueryMetricsreplaces the shown numbers (and leaves a running query's busy message alone); unit tests added.Not covered: a widget test of the workspace itself (it needs a database delegate); the two behaviours are small and sit on the tested
QueryaShellStatus.