Repository navigation
fix(ext-tester): inject the --connect password like the app does - #1628
Merged
Merged
Conversation
…tials, like the app (#1487) A driver that takes its password only from the injected secret (the ClickHouse driver) could not authenticate under the tester: the password was in the db.connect payload, which such a driver ignores. The harness now injects it first and leaves it out of db.connect.
github-actions
Bot
added
bug
Open
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by testing the real ClickHouse driver (
QueryaHub/clickhouse-query-ext1.0.2) for the extension registry: it connected to the test database but failedAUTHENTICATION_FAILEDalthough the credentials work. The driver reads its password only fromsystem.injectCredentials(the app's way:bridge.injectCredentialsbeforedb.connect, no password in the connect payload), and the harness put it intodb.connectonly.system.injectCredentials {connectionId, password}beforedb.connectwhen--connecthas a non-emptypassword, and leavespasswordout of the connect params. No password: no call, no new check.system.injectCredentialsis a recommended method (protocol since 0.4.11): a plugin without it only warns, but thendb.connectshows the real consequence.The released testers (up to 0.4.19) still behave the old way; the registry's CI uses the released tester, so the ClickHouse record waits for the release that carries this. Not run locally; CI decides.